Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scroll over histogram handling by exposure module #17877

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix scroll over histogram handling by exposure module #17877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/libs/histogram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1755,18 +1755,18 @@ static gboolean _eventbox_scroll_callback(GtkWidget *widget,
// bubble to adjusting the overall widget size
gtk_widget_event(d->scope_draw, (GdkEvent*)event);
}
else if(d->highlight != DT_LIB_HISTOGRAM_HIGHLIGHT_NONE)
{
gboolean black = d->highlight == DT_LIB_HISTOGRAM_HIGHLIGHT_BLACK_POINT;
if(black) { event->delta_x *= -1; event->delta_y *= -1; }
dt_dev_exposure_handle_event((GdkEvent *)event, black);
}
// note we are using unit rather than smooth scroll events, as
// exposure changes can get laggy if handling a multitude of smooth
// scroll events
else if(dt_gui_get_scroll_unit_delta(event, &delta_y) && delta_y != 0)
{
if(d->highlight != DT_LIB_HISTOGRAM_HIGHLIGHT_NONE)
{
gboolean black = d->highlight == DT_LIB_HISTOGRAM_HIGHLIGHT_BLACK_POINT;
if(black) { event->delta_x *= -1; event->delta_y *= -1; }
dt_dev_exposure_handle_event((GdkEvent *)event, black);
}
else if(d->scope_type == DT_LIB_HISTOGRAM_SCOPE_VECTORSCOPE)
if(d->scope_type == DT_LIB_HISTOGRAM_SCOPE_VECTORSCOPE)
{
if(dt_modifier_is(event->state, GDK_SHIFT_MASK)) // SHIFT+SCROLL
{
Expand Down
Loading