Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surface blur (bilateral) #17884

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

jenshannoschwalm
Copy link
Collaborator

We must restrict the used radius to what is available in current roi. Otherwise wrong data are read, possibly even out-of-bounds.

Fixes #17870

Possibly related: #15956

Release note: Fixed surface blur radius calculation possibly resulting in garbled output.

We must restrict the used radius to what is available in current roi.
Otherwise wrong data are read, possibly even out-of-bounds.
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes labels Nov 23, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Nov 23, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed, thanks!

@TurboGit TurboGit merged commit 52c5cb8 into darktable-org:master Nov 24, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the bilateral_fix branch November 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface blur causing visual glitches in darkroom.
2 participants