Raise a error on an attempt to partition a Global Temporary Table. Th…

…is is

not supported, again not because PostgreSQL do not allow partition on
temporary table but because other RDBMS like Oracle, DB2 and MySQL do not
support it.

Add a regression test on partitioning.

Makefile

@@ -23,7 +23,7 @@ DATA = $(wildcard updates/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql
 TESTS        = 00_init 01_oncommitdelete 02_oncommitpreserve \
 	       03_createontruncate 04_rename 05_useindex \
 	       06_createas 07_createlike 08_plplgsql \
-	       09_transaction 10_foreignkey
+	       09_transaction 10_foreignkey 11_partition
 
 REGRESS      = $(patsubst test/sql/%.sql,%,$(TESTS))
 REGRESS_OPTS = --inputdir=test

README.md

@@ -279,6 +279,13 @@ SQL Server or MySQL.
 
 	ORA-14455: attempt to create referential integrity constraint on temporary table.  
 
+#### Partitioning
+
+Partitioning on Global Temporary Table is not supported, again not because
+PostgreSQL do not allow partition on temporary table but because other RDBMS
+like Oracle, DB2 and MySQL do not support it. SQL Server supports partition
+on global temporary table.
+
 
 ### [How the extension really works](#how-the-extension-really-works)
 

pgtt.c

@@ -553,6 +553,14 @@ gtt_check_command(GTT_PROCESSUTILITY_PROTO)
 			if (regexec(&create_global_regexv, queryString, 0, 0, 0) != 0)
 				break;
 
+			/*
+			 * We do not allow partitioning on GTT, not that PostgreSQL can
+			 * not do it but because we want to mimic the Oracle or other
+			 * RDBMS behavior.
+			 */
+			if (stmt->partspec != NULL)
+				elog(ERROR, "Global Temporary Table do not support partitioning.");
+
 			/*
 			 * What to do at commit time for global temporary relations
 			 * default is ON COMMIT PRESERVE ROWS (do nothing)

test/expected/10_foreignkey.out

@@ -1,3 +1,10 @@
+----
+-- Regression test to Global Temporary Table implementation
+--
+-- Test for unsupported foreign keys on GTT.
+--
+----
+-- Import the library
 LOAD 'pgtt';
 -- Must throw ERROR: attempt to create referential integrity constraint on temporary table.
 CREATE /*GLOBAL*/ TEMPORARY TABLE t2 (c1 integer, FOREIGN KEY (c1) REFERENCES source (id));
@@ -8,3 +15,4 @@ CREATE /*GLOBAL*/ TEMPORARY TABLE t2 (c1 integer);
 -- Must throw ERROR: attempt to create referential integrity constraint on temporary table.
 ALTER TABLE t2 ADD FOREIGN KEY (c1) REFERENCES source (id);
 ERROR:  attempt to create referential integrity constraint on global temporary table
+ROLLBACK;

test/expected/11_partition.out

@@ -0,0 +1,15 @@
+----
+-- Regression test to Global Temporary Table implementation
+--
+-- Test for unsupported partitioning on GTT.
+--
+----
+-- Import the library
+LOAD 'pgtt';
+-- Must throw ERROR:  Global Temporary Table do not support partitioning.
+CREATE /*GLOBAL*/ TEMPORARY TABLE measurement (
+    logdate         date not null,
+    peaktemp        int,
+    unitsales       int
+) PARTITION BY RANGE (logdate);
+ERROR:  Global Temporary Table do not support partitioning.

test/sql/10_foreignkey.sql

@@ -1,8 +1,15 @@
+----
+-- Regression test to Global Temporary Table implementation
+--
+-- Test for unsupported foreign keys on GTT.
+--
+----
+-- Import the library
 LOAD 'pgtt';
 -- Must throw ERROR: attempt to create referential integrity constraint on temporary table.
 CREATE /*GLOBAL*/ TEMPORARY TABLE t2 (c1 integer, FOREIGN KEY (c1) REFERENCES source (id));
 BEGIN;
 CREATE /*GLOBAL*/ TEMPORARY TABLE t2 (c1 integer);
 -- Must throw ERROR: attempt to create referential integrity constraint on temporary table.
 ALTER TABLE t2 ADD FOREIGN KEY (c1) REFERENCES source (id);
-
+ROLLBACK;

test/sql/11_partition.sql

@@ -0,0 +1,14 @@
+----
+-- Regression test to Global Temporary Table implementation
+--
+-- Test for unsupported partitioning on GTT.
+--
+----
+-- Import the library
+LOAD 'pgtt';
+-- Must throw ERROR:  Global Temporary Table do not support partitioning.
+CREATE /*GLOBAL*/ TEMPORARY TABLE measurement (
+    logdate         date not null,
+    peaktemp        int,
+    unitsales       int
+) PARTITION BY RANGE (logdate);