Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5 #40

Closed
wants to merge 3 commits into from
Closed

Release 3.5 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73d4aa3
Bump coincurve max version to support 0.19
darosior Jan 23, 2024
fa888b0
Release version 3.5
darosior Jan 23, 2024
eba1edf
[TMP] fixup Coincurve missing dependency under Windows
darosior Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ jobs:
python -m pip install --upgrade pip
pip install pytest
pip install -r requirements.txt -r tests/requirements.txt
python setup.py install
- name: Under Windows, install coincurve's missing `cffi` dependency
if: matrix.os == 'windows-latest'
run: pip install cffi
- name: Actually run the tests
run: python setup.py install
- name: Test with pytest
run: |
pytest -vvv
Expand Down
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# 3.5

- Support Coincurve up to version 19. This version supports the latest libsecp.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Support Coincurve up to version 19. This version supports the latest libsecp.
- Support Coincurve up to version 20. This version supports the latest libsecp.


# 3.4

- Support Coincurve up to version 18. This version includes support for BIP340 x-only keys and
Schnorr signatures.


# 3.3

- Implement a pure Python fallback for RIPEMD160 in case `hashlib` does not provide it.
Expand Down
2 changes: 1 addition & 1 deletion bip32/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from .bip32 import BIP32, PrivateDerivationError, InvalidInputError
from .utils import BIP32DerivationError, HARDENED_INDEX

__version__ = "3.4"
__version__ = "3.5"

__all__ = [
"BIP32",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
coincurve>=15.0,<19
coincurve>=15.0,<=19
base58~=2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

coincurve<=19,>=15.0 not satisfied by version 19.0.1

I guess you meant <20 instead of <=19?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coincurve 19 is yanked

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what you mean. 19.0.0 is marked as yanked. I was mentioning 19.0.1 which is not.
https://pypi.org/project/coincurve/#history

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added why <=19 is not working

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
coincurve>=15.0,<=19
coincurve>=15.0,<21

Loading