Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix eslint config #249

Merged

Conversation

floydnant
Copy link
Contributor

@floydnant floydnant commented Jan 29, 2025

  • Fixes hardcoded reference to user folder
  • Fixes eslint config itself getting linted and thereby throwing an error like "this file is not in the tsconfig, but is being linted" or sth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit awkward as the entire file got formatted, but apparently thats exactly how the prettier config wants it.

Copy link
Owner

@darraghoriordan darraghoriordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for this. I hadn't spotted that hardcoded path at all

@darraghoriordan darraghoriordan merged commit 68b4b00 into darraghoriordan:main Jan 30, 2025
3 checks passed
@darraghoriordan
Copy link
Owner

🎉 This PR is included in version 6.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@darraghoriordan
Copy link
Owner

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants