This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Regenerate protos and update protobuf constraint #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves/changes the regeneration script: * Use the protoc_plugin from the pubspec.yaml - so the constraint is fixed * Move it to `tool/` for better discovery. * Mention in `README.md` for better discovery. * Clone into `tmp/` so we don't have to redownload everything * Compile all protos in one command (much faster) * Use `dart format` instead of `dartfmt` (actually works on modern SDK). Prepares for a new publication.
sigurdm
force-pushed
the
adjust_protobuf_upper_bound
branch
from
a5c37e2 to
878fad6
Compare
sigurdm
changed the title
jonasfj
approved these changes
Sep 10, 2024
devoncarew
pushed a commit
to dart-lang/labs
that referenced
this pull request
Oct 1, 2024
…ine#182) * Allow newer protobuf versions * Regenerate protos and update protobuf constraint Improves/changes the regeneration script: * Use the protoc_plugin from the pubspec.yaml - so the constraint is fixed * Move it to `tool/` for better discovery. * Mention in `README.md` for better discovery. * Clone into `tmp/` so we don't have to redownload everything * Compile all protos in one command (much faster) * Use `dart format` instead of `dartfmt` (actually works on modern SDK). Prepares for a new publication. * Remove obsolete test script * Fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves/changes the regeneration script:
fixed
tool/for better discovery.README.mdfor better discovery.tmp/so we don't have to redownload everythingdart formatinstead ofdartfmt(actually works on modern SDK).Prepares for a new publication.