-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
fe4fe22
to
4c3b63b
Compare
4c3b63b
to
176856c
Compare
176856c
to
180d067
Compare
@srujzs fwiw force pushing in GitHub doesn't work well because it destroys all history (I can't tell what you actually changed in that last push). If you can do a merge from master instead in the future that will help me out :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the formatter change
Ah sorry about that! I've been pushing to avoid unnecessary commits from polluting the branch but messing with the review is way worse. |
No worries, really it is just specific to GitHub and how its reviews work. Fwiw when we merge we squash/merge so its always just one commit. So you don't have to worry about branch history really (and it is useful for reviewing so you can see diffs since last review). |
Corresponds to the syntax defined in https://github.com/dart-lang/language/blob/main/accepted/future-releases/extension-types/feature-specification.md#syntax.