Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Add support for extension types #437

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Nov 17, 2023

Corresponds to the syntax defined in https://github.com/dart-lang/language/blob/main/accepted/future-releases/extension-types/feature-specification.md#syntax.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

pubspec.yaml Outdated Show resolved Hide resolved
lib/src/emitter.dart Outdated Show resolved Hide resolved
@jakemac53
Copy link
Contributor

@srujzs fwiw force pushing in GitHub doesn't work well because it destroys all history (I can't tell what you actually changed in that last push). If you can do a merge from master instead in the future that will help me out :).

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the formatter change

@srujzs
Copy link
Contributor Author

srujzs commented Nov 20, 2023

fwiw force pushing in GitHub doesn't work well because it destroys all history (I can't tell what you actually changed in that last push).

Ah sorry about that! I've been pushing to avoid unnecessary commits from polluting the branch but messing with the review is way worse.

@jakemac53
Copy link
Contributor

Ah sorry about that! I've been pushing to avoid unnecessary commits from polluting the branch but messing with the review is way worse.

No worries, really it is just specific to GitHub and how its reviews work. Fwiw when we merge we squash/merge so its always just one commit. So you don't have to worry about branch history really (and it is useful for reviewing so you can see diffs since last review).

@jakemac53 jakemac53 merged commit 10ebf2a into dart-archive:master Nov 20, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants