Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Add ListExtensions.firstOrNull, lastOrNull, singleOrNull. #312

Closed

Conversation

scheglov
Copy link
Contributor

@scheglov scheglov commented Sep 6, 2023

No description provided.

@scheglov scheglov requested a review from natebosch September 6, 2023 17:39
@natebosch
Copy link
Contributor

@lrhn - should we define these in the SDK instead?

@scheglov
Copy link
Contributor Author

scheglov commented Oct 9, 2023

This is not urgent at all, but it would be nice to get some reaction to it :-)

@natebosch
Copy link
Contributor

I like the APIs. I think it would be worth moving to the SDK since that is where the definitions are for Iterable. Unless @lrhn has concerns I'd be inclined to close this and reopen as a CL in the SDK.

@lrhn
Copy link
Contributor

lrhn commented Oct 13, 2023

SGTM, move it!

@natebosch
Copy link
Contributor

@scheglov - do you want to open a CL in the SDK or should I?

@scheglov
Copy link
Contributor Author

I opened dart-lang/sdk#53756

@scheglov scheglov closed this Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants