Deprecate whereNotNull from IterableNullableExtensions

[oprypin]

Dart SDK since 3.0 has an exact equivalent extension nonNulls in the core.

---

• References Deprecate IterableExtensions that have exact equivalents in the SDK dart-lang/core#671
• Closes rewrite whereNotNull without sync* dart-lang/core#651
• Closes Provide faster implementation for whereNotNull #274

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[natebosch]

cc @bwilkerson - would it be feasible to add support in dart_fix.yaml to replace a method with no arguments with a field? I don't think we currently have a way to automate the fix we need:

import 'package:collection/collection.dart';

void main() {
  [].whereNotNull().join('');
}

Should become

void main() {
  [].nonNulls.join('');
}

The transform I think I want, but is currently an error:

  - title: 'Replace whereNotNull() with core nonNulls'
    date: 2024-01-25
    element:
      uris: ['collection.dart']
      method: 'whereNotNull'
      inExtension: 'IterableExtension'
    changes:
      - kind: 'replacedBy'
        newElement:
          uris: ['dart:core']
          field: 'nonNulls'
          inClass: 'NullableIterableExtensions'

[kevmoo]

Are we going to move forward with this – or should we wait until after 1.19.0? @natebosch

[lrhn]

We can remove it in the next major version, which may be the one which switches to Dart 3.0. Maybe.

[kevmoo]

Well the constraint @ master right now is ^3.1.0 – so this would be as good a time as any.