This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jakemac53 - we don't expect significant changes to wasm support in the test runner do we? Any concerns if we start using the current implementation on CI? |
I've already wired it up for a few other packages, FYI – with @jakemac53 approval |
natebosch
approved these changes
Feb 1, 2024
Yeah, it isn't under any experiment flags any longer, we should be good to use it wherever. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 6, 2024
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, file, fixnum, glob, html, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, webkit_inspection_protocol, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/03386ba..7dc7fe0): 7dc7fe0 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/args#263) async (https://github.com/dart-lang/async/compare/e83d054..24266ca): 24266ca 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/async#266) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/3d9cd58..372b8b5): 372b8b5 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/bazel_worker#85) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a62e416..c8a0c8b): c8a0c8b 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/benchmark_harness#99) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/caea8d4..be88351): be88351 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/boolean_selector#56) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/c68ec25..74a0efe): 74a0efe 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/browser_launcher#54) cli_util (https://github.com/dart-lang/cli_util/compare/e5b38ac..ffeb5d2): ffeb5d2 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/cli_util#97) clock (https://github.com/dart-lang/clock/compare/f975668..daf0fad): daf0fad 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/clock#60) collection (https://github.com/dart-lang/collection/compare/2d57a82..fc616ff): fc616ff 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/collection#334) 1aff3be 2024-02-01 Kevin Moore Test on dart2wasm (dart-archive/collection#333) convert (https://github.com/dart-lang/convert/compare/f8a72d6..d4d6368): d4d6368 2024-02-01 Kevin Moore Test dart2wasm (dart-archive/convert#101) 48642c5 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/convert#100) crypto (https://github.com/dart-lang/crypto/compare/f2efb98..c954015): c954015 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/crypto#161) csslib (https://github.com/dart-lang/csslib/compare/ec86ee5..62ae85e): 62ae85e 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/csslib#196) dartdoc (https://github.com/dart-lang/dartdoc/compare/5cac62b..457c34e): 457c34ec 2024-02-05 dependabot[bot] Bump dart-lang/setup-dart from 1.6.1 to 1.6.2 (dart-lang/dartdoc#3646) 2665e44b 2024-02-05 Parker Lougheed A few minor documentation updates (dart-lang/dartdoc#3641) 69ca6a80 2024-01-31 Daco Harkes Roll analyzer and release 8.0.5 (dart-lang/dartdoc#3644) ecosystem (https://github.com/dart-lang/ecosystem/compare/9ee08a4..7d8ec47): 7d8ec47 2024-02-02 Moritz Checkout submodules for auto-publishing (dart-lang/ecosystem#236) 878fee1 2024-02-01 dependabot[bot] Bump actions/download-artifact from 4.1.0 to 4.1.1 (dart-lang/ecosystem#233) 1be1df3 2024-02-01 dependabot[bot] Bump actions/cache from 3.3.2 to 4.0.0 (dart-lang/ecosystem#231) c2731dc 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/ecosystem#234) f347760 2024-02-01 dependabot[bot] Bump peter-evans/create-or-update-comment (dart-lang/ecosystem#235) da68dbc 2024-02-01 dependabot[bot] Bump peter-evans/find-comment (dart-lang/ecosystem#232) file (https://github.com/google/file.dart/compare/cd3a932..3aa0649): 3aa0649 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/file.dart#235) fixnum (https://github.com/dart-lang/fixnum/compare/3e08c0d..570b28a): 570b28a 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/fixnum#124) glob (https://github.com/dart-lang/glob/compare/7c9a121..ef5f065): ef5f065 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/glob#87) html (https://github.com/dart-lang/html/compare/910f6d7..327e37a): 327e37a 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.1 to 1.6.2 (dart-archive/html#237) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/491f7c6..ba9d07f): ba9d07f 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.1 to 1.6.2 (dart-lang/http_multi_server#64) http_parser (https://github.com/dart-lang/http_parser/compare/224c1a9..84db8b0): 84db8b0 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/http_parser#86) fea0cf2 2024-02-01 Kevin Moore Test dart2wasm (dart-archive/http_parser#85) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/ac1fabd..639857b): 639857b 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/json_rpc_2#109) lints (https://github.com/dart-lang/lints/compare/3810f8b..90a61e4): 90a61e4 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/lints#176) logging (https://github.com/dart-lang/logging/compare/e04942d..cbaf4ee): cbaf4ee 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.1 to 1.6.2 (dart-archive/logging#157) markdown (https://github.com/dart-lang/markdown/compare/a8288ca..c2b8429): c2b8429 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/markdown#580) matcher (https://github.com/dart-lang/matcher/compare/d9cf4f6..d954c8d): d954c8d 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/matcher#241) mime (https://github.com/dart-lang/mime/compare/99fbdcc..9a16871): 9a16871 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/mime#115) mockito (https://github.com/dart-lang/mockito/compare/0422551..7d6632f): 7d6632f 2024-02-05 Oleh Prypin Sort `import` directives in all *.dart code native (https://github.com/dart-lang/native/compare/0eafd54..876f9a1): 876f9a19 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/native#958) package_config (https://github.com/dart-lang/package_config/compare/5a0bc19..4a7042b): 4a7042b 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/package_config#146) path (https://github.com/dart-lang/path/compare/57a049c..a7b6960): a7b6960 2024-02-01 Kevin Moore Test on dart2wasm (dart-archive/path#159) 7e74cc9 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/path#158) pool (https://github.com/dart-lang/pool/compare/4c49000..782da82): 782da82 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/pool#80) pub_semver (https://github.com/dart-lang/pub_semver/compare/4572181..3175ba0): 3175ba0 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/pub_semver#98) shelf (https://github.com/dart-lang/shelf/compare/823966f..b432620): b432620 2024-02-01 dependabot[bot] Bump actions/cache from 3.3.2 to 4.0.0 (dart-lang/shelf#406) 0f88f26 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/shelf#405) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/2209626..c756496): c756496 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/source_map_stack_trace#46) source_maps (https://github.com/dart-lang/source_maps/compare/87dc587..55e92a4): 55e92a4 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/source_maps#86) source_span (https://github.com/dart-lang/source_span/compare/9398e24..21a403a): 21a403a 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/source_span#107) sse (https://github.com/dart-lang/sse/compare/8d2e2f0..e483b14): e483b14 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/sse#101) stack_trace (https://github.com/dart-lang/stack_trace/compare/0f4710c..155f12c): 155f12c 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/stack_trace#149) stream_channel (https://github.com/dart-lang/stream_channel/compare/178104d..851336f): 851336f 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/stream_channel#99) string_scanner (https://github.com/dart-lang/string_scanner/compare/ebc30a3..a2bcdb5): a2bcdb5 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/string_scanner#68) sync_http (https://github.com/dart-lang/sync_http/compare/f96db95..b849559): b849559 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (google/sync_http.dart#43) term_glyph (https://github.com/dart-lang/term_glyph/compare/4c5a496..85a4aa6): 85a4aa6 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/term_glyph#47) test (https://github.com/dart-lang/test/compare/6700049..a3f05ec): a3f05ec8 2024-02-01 dependabot[bot] Bump actions/cache from 3.3.2 to 4.0.0 (dart-lang/test#2181) dadf801e 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/test#2182) 0d1c20c6 2024-02-01 dependabot[bot] Bump actions/upload-artifact from 4.0.0 to 4.3.0 (dart-lang/test#2179) aa296b33 2024-02-01 dependabot[bot] Bump github/codeql-action from 3.22.12 to 3.23.2 (dart-lang/test#2180) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/59ce97f..35f97af): 35f97af 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/test_descriptor#61) test_process (https://github.com/dart-lang/test_process/compare/d68de5b..7fe39af): 7fe39af 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/test_process#53) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/6edf535..9862703): 9862703 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/test_reflective_loader#57) tools (https://github.com/dart-lang/tools/compare/f6e67f2..2ef7673): 2ef7673 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/tools#231) typed_data (https://github.com/dart-lang/typed_data/compare/6f6d81d..375efaa): 375efaa 2024-02-01 Kevin Moore Test dart2wasm (dart-archive/typed_data#80) c6bb459 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/typed_data#79) usage (https://github.com/dart-lang/usage/compare/e99690a..67ecd7d): 67ecd7d 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-archive/usage#202) watcher (https://github.com/dart-lang/watcher/compare/66cd694..21858a4): 21858a4 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/watcher#162) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/667c55e..07295b9): 07295b9 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (google/webkit_inspection_protocol.dart#119) 39d264b 2024-02-01 dependabot[bot] Bump nanasess/setup-chromedriver (google/webkit_inspection_protocol.dart#118) yaml (https://github.com/dart-lang/yaml/compare/509fd72..e598443): e598443 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/yaml#157) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/47eb20e..2a9a11b): 2a9a11b 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/yaml_edit#64) Change-Id: I9dd87b6d8d77e99a2a6f66f6ef6d8582da18368b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350680 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.