Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Only send updates on frames and pings being received when there are listeners #137

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Jan 5, 2024

Fixes flutter/flutter#139650 when GRPC adapts the change.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from mraleph January 8, 2024 12:15
Copy link

github-actions bot commented Jan 8, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:http2 2.3.0 ready to publish v2.3.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem changed the title Switch to callbacks from streams for ping handling Only send updates on frames and pings being received when there are listeners Jan 8, 2024
@mosuem mosuem merged commit 1849a26 into master Jan 8, 2024
6 checks passed
@mosuem mosuem deleted the switchPingsToCallback branch January 8, 2024 13:13
mosuem added a commit to dart-lang/http that referenced this pull request Oct 17, 2024
…2#137)

* Switch to callbacks from streams for ping handling

* Debugging

* Revert "Debugging"

This reverts commit 910c1e1b0527f508df68cb596cf88c014028952d.

* Revert "Switch to callbacks from streams for ping handling"

This reverts commit c4f4730940961d08b31bd6e60a1ba2d620d2c6d3.

* Fix by using `hasListener`

* Rev version

* Rerun checks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Memory leaks when receiving GRPC continuos server stream
2 participants