Skip to content
This repository has been archived by the owner on Feb 23, 2018. It is now read-only.

Update for package:test; onPrint->onMessage #3

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

davidmorgan
Copy link
Contributor

No description provided.

@nex3
Copy link
Contributor

nex3 commented Dec 12, 2017

What's the context for this pull request? My understanding was that metatest was no longer in use now that scheduled_test has been phased out.

@davidmorgan
Copy link
Contributor Author

I'm getting the last few packages in google3 strong mode compliant.

I still see uses of scheduled_test from barback, dart_style, glob, shelf_proxy, shelf_static and watcher. So removing it (and hence metatest) doesn't look like an option.

@davidmorgan
Copy link
Contributor Author

Friendly ping. Just a few packages left now :)

I can also apply this patch internally only if you prefer.

@nex3
Copy link
Contributor

nex3 commented Dec 15, 2017

I still see uses of scheduled_test from barback, dart_style, glob, shelf_proxy, shelf_static and watcher. So removing it (and hence metatest) doesn't look like an option.

Of these, I believe only barback and watcher still use scheduled_test—maybe the others still need to be pulled into Google3?

I'll see if I can get watcher moved to pure test, and I've filed dart-archive/barback#93 for moving barback. In the meantime, I guess it makes sense to continue updating this... can you bump the version number and release?

@davidmorgan
Copy link
Contributor Author

(Sorry for slow response). Sure. What should the version number be? I've never used a version scheme with '+' in there.

By release, do you mean pub and/or github? (Not sure if I have permission to release to pub?).

Thanks. (I'm no longer blocked on this, FWIW).

@nex3
Copy link
Contributor

nex3 commented Jan 2, 2018

(Sorry for slow response). Sure. What should the version number be? I've never used a version scheme with '+' in there.

0.2.2+4. See this doc for details.

By release, do you mean pub and/or github?

To pub. I've added you as an uploader.

@davidmorgan
Copy link
Contributor Author

Done. Thanks.

@davidmorgan davidmorgan merged commit 8f80223 into master Jan 8, 2018
@davidmorgan davidmorgan deleted the davidmorgan-patch-1 branch January 8, 2018 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants