Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package:async): migrate the Result class to sealed class #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

utamori
Copy link

@utamori utamori commented Oct 27, 2024

By changing the result class from an abstract class to a sealed class,
it will be possible for users to perform exhaustive checks.

#364

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@lrhn
Copy link
Member

lrhn commented Nov 14, 2024

It's not a bad idea, but it is also potentially breaking.

I'd do it as part of a larger change that adds class modifiers everywhere where they belong in the package, which may require a major version increment.
(Would probably also make the ValueResult and ErrorResult classes final at that point.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants