Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get needed version from API tool in health check #213

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jan 2, 2024

Thanks to bmw-tech/dart_apitool#164.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Jan 2, 2024

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.4.2 ready to publish
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/firehose/lib/src/health/health.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 2.1.1 2.1.1 2.1.1 ✔️
firehose None 0.4.1 0.4.2 0.4.1 ✔️

Copy link

github-actions bot commented Jan 2, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.4.2 ready to publish firehose-v0.4.2
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem requested a review from devoncarew January 2, 2024 16:01
@mosuem mosuem merged commit dc44e82 into main Jan 2, 2024
15 of 16 checks passed
@mosuem mosuem deleted the versionFromTool branch January 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants