Merge branch 'master' into cronet_fix

dart-lang · Nov 2, 2023 · 168a284 · 168a284
2 parents e1c4d6e + f953aec
commit 168a284
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/pkgs/cronet_http/CHANGELOG.md b/pkgs/cronet_http/CHANGELOG.md
@@ -3,6 +3,8 @@
 * Require `package:jni >= 0.7.1` so that depending on `package:cronet_http` 
   does not break macOS builds.
 
+* Fix obsolete `CronetClient()` constructor usage.
+
 ## 0.4.0
 
 * Use more efficient operations when copying bytes between Java and Dart.

diff --git a/pkgs/cronet_http/lib/cronet_http.dart b/pkgs/cronet_http/lib/cronet_http.dart
@@ -10,7 +10,7 @@
 /// import 'package:cronet_http/cronet_http.dart';
 ///
 /// void main() async {
-///   var client = CronetClient();
+///   var client = CronetClient.defaultCronetEngine();
 ///   final response = await client.get(
 ///       Uri.https('www.googleapis.com', '/books/v1/volumes', {'q': '{http}'}));
 ///   if (response.statusCode != 200) {

diff --git a/pkgs/cronet_http/lib/src/cronet_client.dart b/pkgs/cronet_http/lib/src/cronet_client.dart
@@ -235,7 +235,7 @@ jb.UrlRequestCallbackProxy_UrlRequestCallbackInterface _urlRequestCallbacks(
 /// For example:
 /// ```
 /// void main() async {
-///   var client = CronetClient();
+///   var client = CronetClient.defaultCronetEngine();
 ///   final response = await client.get(
 ///       Uri.https('www.googleapis.com', '/books/v1/volumes', {'q': '{http}'}));
 ///   if (response.statusCode != 200) {