Fix analysis issues

dart-lang · Feb 21, 2024 · 653e5da · 653e5da
1 parent af40a78
commit 653e5da
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 23 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
diff --git a/pkgs/http_profile/lib/http_profile.dart b/pkgs/http_profile/lib/http_profile.dart
@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async' show StreamController, StreamSink;
-import 'dart:developer' show addHttpClientProfilingData, Service, Timeline;
+import 'dart:developer' show Service, addHttpClientProfilingData;
 import 'dart:io' show HttpClient, HttpClientResponseCompressionState;
 import 'dart:isolate' show Isolate;
 
@@ -288,8 +288,18 @@ final class HttpClientRequestProfile {
   /// Usage example:
   ///
   /// ```dart
-  /// profile.addEvent(HttpProfileRequestEvent(DateTime.now(), "Connection Established");
-  /// profile.addEvent(HttpProfileRequestEvent(DateTime.now(), "Remote Disconnected");
+  /// profile.addEvent(
+  ///   HttpProfileRequestEvent(
+  ///     timestamp: DateTime.now(),
+  ///     name: "Connection Established",
+  ///   ),
+  /// );
+  /// profile.addEvent(
+  ///   HttpProfileRequestEvent(
+  ///     timestamp: DateTime.now(),
+  ///     name: "Remote Disconnected",
+  ///   ),
+  /// );
   /// ```
   void addEvent(HttpProfileRequestEvent event) {
     (_data['events'] as List<Map<String, dynamic>>).add(event._toJson());

diff --git a/pkgs/http_profile/pubspec.yaml b/pkgs/http_profile/pubspec.yaml
@@ -8,7 +8,7 @@ publish_to: none
 
 environment:
   # TODO(derekxu16): Change the following constraint to ^3.4.0 before publishing this package.
-  sdk: ^3.4.0-149.0.dev
+  sdk: ^3.4.0-154.0.dev
 
 dependencies:
   test: ^1.24.9

diff --git a/pkgs/http_profile/test/populating_profiles_test.dart b/pkgs/http_profile/test/populating_profiles_test.dart
@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:developer' show getHttpClientProfilingData, Service;
+import 'dart:developer' show Service, getHttpClientProfilingData;
 import 'dart:io';
 import 'dart:isolate' show Isolate;