Merge branch 'master' into misc/update-flutter-links

.github/ISSUE_TEMPLATE/2--package-http---i-found-a-bug.md

@@ -12,4 +12,4 @@ Please describe the bug and how to reproduce it.
 
 Note that if the bug can also be reproduced when going through the interfaces provided by `dart:html` or `dart:io` directly the bug should be filed against the Dart SDK: https://github.com/dart-lang/sdk/issues
 
-A failure to make an http request is more often a problem with the environment than with the client.
+A failure to make an HTTP request is more often a problem with the environment than with the client.

pkgs/cronet_http/README.md

@@ -23,7 +23,7 @@ Using [Cronet][], rather than the socket-based
 
 ## Using
 
-The easiest way to use this library is via the the high-level interface
+The easiest way to use this library is via the high-level interface
 defined by [package:http Client][].
 
 This approach allows the same HTTP code to be used on all platforms, while

pkgs/cronet_http/example/lib/main.dart

@@ -63,7 +63,7 @@ class _HomePageState extends State<HomePage> {
   }
 
   // Get the list of books matching `query`.
-  // The `get` call will automatically use the `client` configurated in `main`.
+  // The `get` call will automatically use the `client` configured in `main`.
   Future<List<Book>> _findMatchingBooks(String query) async {
     final response = await _client.get(
       Uri.https(

pkgs/cupertino_http/README.md

@@ -7,7 +7,7 @@ A macOS/iOS Flutter plugin that provides access to the
 ## Motivation
 
 Using the [Foundation URL Loading System][], rather than the socket-based
-[dart:io HttpClient][] implemententation, has several advantages:
+[dart:io HttpClient][] implementation, has several advantages:
 
 1. It automatically supports iOS/macOS platform features such VPNs and HTTP
    proxies. 
@@ -17,7 +17,7 @@ Using the [Foundation URL Loading System][], rather than the socket-based
 
 ## Using
 
-The easiest way to use this library is via the the high-level interface
+The easiest way to use this library is via the high-level interface
 defined by [package:http Client][].
 
 This approach allows the same HTTP code to be used on all platforms, while

pkgs/cupertino_http/example/lib/main.dart

@@ -62,7 +62,7 @@ class _HomePageState extends State<HomePage> {
   }
 
   // Get the list of books matching `query`.
-  // The `get` call will automatically use the `client` configurated in `main`.
+  // The `get` call will automatically use the `client` configured in `main`.
   Future<List<Book>> _findMatchingBooks(String query) async {
     final response = await _client.get(
       Uri.https(

pkgs/cupertino_http/lib/src/cupertino_web_socket.dart

@@ -84,7 +84,7 @@ class CupertinoWebSocket implements WebSocket {
         //    called and `_connectionClosed` is a no-op.
         // 2. we sent a close Frame (through `close()`) and `_connectionClosed`
         //    is a no-op.
-        // 3. an error occured (e.g. network failure) and `_connectionClosed`
+        // 3. an error occurred (e.g. network failure) and `_connectionClosed`
         //    will signal that and close `event`.
         webSocket._connectionClosed(
             1006, Data.fromList('abnormal close'.codeUnits));

pkgs/flutter_http_example/README.md

@@ -24,7 +24,7 @@ the Dart virtual machine, meaning all platforms except the web browser.
 This library used to create `package:http` `Client`s when the app is run inside
 a web browser.
 
-Web configuration must be done in a seperate library because Dart code cannot
+Web configuration must be done in a separate library because Dart code cannot
 import `dart:ffi` or `dart:io` when run in a web browser.
 
 ### `main.dart`

pkgs/flutter_http_example/lib/main.dart

@@ -15,6 +15,14 @@ import 'http_client_factory.dart'
 
 void main() {
   runApp(Provider<Client>(
+      // `Provider` calls its `create` argument once when a `Client` is
+      // first requested (through `BuildContext.read<Client>()`) and uses that
+      // same instance for all future requests.
+      //
+      // Reusing the same `Client` may:
+      // - reduce memory usage
+      // - allow caching of fetched URLs
+      // - allow connections to be persisted
       create: (_) => http_factory.httpClient(),
       child: const BookSearchApp(),
       dispose: (_, client) => client.close()));
@@ -51,7 +59,7 @@ class _HomePageState extends State<HomePage> {
   }
 
   // Get the list of books matching `query`.
-  // The `get` call will automatically use the `client` configurated in `main`.
+  // The `get` call will automatically use the `client` configured in `main`.
   Future<List<Book>> _findMatchingBooks(String query) async {
     final response = await _client.get(
       Uri.https(

pkgs/http/README.md

@@ -119,7 +119,7 @@ There are multiple implementations of the `package:http` [`Client`][client] inte
 You can change implementations without changing your application code, except
 for a few lines of [configuration](#2-configure-the-http-client).
 
-Some well supported implementations are:
+Some well-supported implementations are:
 
 | Implementation | Supported Platforms | SDK | Caching | HTTP3/QUIC | Platform Native | 
 | -------------- | ------------------- | ----| ------- | ---------- | --------------- |
@@ -130,7 +130,7 @@ Some well supported implementations are:
 | [`package:fetch_client`][fetch] — [`FetchClient`][fetchclient] | Web | Dart, Flutter | ✅︎ | ✅︎ | ✅︎ |
 
 > [!TIP]
-> If you are writing a Dart package or Flutter pluggin that uses
+> If you are writing a Dart package or Flutter plugin that uses
 > `package:http`, you should not depend on a particular [`Client`][client]
 > implementation. Let the application author decide what implementation is
 > best for their project. You can make that easier by accepting an explicit
@@ -145,7 +145,7 @@ Some well supported implementations are:
 
 ## Configuration
 
-To use a HTTP client implementation other than the default, you must:
+To use an HTTP client implementation other than the default, you must:
 1. Add the HTTP client as a dependency.
 2. Configure the HTTP client.
 3. Connect the HTTP client to the code that uses it.
@@ -204,7 +204,7 @@ Client httpClient() {
 #### Supporting browser and native
 
 If your application can be run in the browser and natively, you must put your
-browser and native configurations in seperate files and import the correct file
+browser and native configurations in separate files and import the correct file
 based on the platform.
 
 For example:
@@ -250,7 +250,7 @@ void main() {
 ```
 
 In Flutter, you can use a one of many
-[state mangement approaches][flutterstatemanagement].
+[state management approaches][flutterstatemanagement].
 
 If you depend on code that uses top-level functions (e.g. `http.post`) or
 calls the [`Client()`][clientconstructor] constructor, then you can use

pkgs/http/lib/src/response.dart

@@ -71,7 +71,7 @@ class Response extends BaseResponse {
 Encoding _encodingForHeaders(Map<String, String> headers) =>
     encodingForCharset(_contentTypeForHeaders(headers).parameters['charset']);
 
-/// Returns the [MediaType] object for the given headers's content-type.
+/// Returns the [MediaType] object for the given headers' content-type.
 ///
 /// Defaults to `application/octet-stream`.
 MediaType _contentTypeForHeaders(Map<String, String> headers) {

pkgs/http_client_conformance_tests/README.md

@@ -40,5 +40,5 @@ void main() {
 }
 ```
 
-**Note**: This package does not have it's own tests, instead it is
+**Note**: This package does not have its own tests, instead it is
 exercised by the tests in `package:http`.

pkgs/http_client_conformance_tests/lib/src/isolate_test.dart

@@ -17,7 +17,7 @@ Future<void> _testPost(Client Function() clientFactory, String host) async {
       () => clientFactory().post(Uri.http(host, ''), body: 'Hello World!'));
 }
 
-/// Tests that the [Client] is useable from Isolates other than the main
+/// Tests that the [Client] is usable from Isolates other than the main
 /// isolate.
 ///
 /// If [canWorkInIsolates] is `false` then the tests will be skipped.

pkgs/http_client_conformance_tests/lib/src/request_body_tests.dart

@@ -261,7 +261,7 @@ void testRequestBody(Client client) {
     });
 
     test('client.send() with persistentConnection', () async {
-      // Do five requests to verify that the connection persistance logic is
+      // Do five requests to verify that the connection persistence logic is
       // correct.
       for (var i = 0; i < 5; ++i) {
         final request = Request('POST', Uri.http(host, ''))

pkgs/ok_http/CHANGELOG.md

@@ -1,4 +1,5 @@
 ## 0.1.0-wip
 
 - Implementation of [`BaseClient`](https://pub.dev/documentation/http/latest/http/BaseClient-class.html) and `send()` method using [`enqueue()` API](https://square.github.io/okhttp/5.x/okhttp/okhttp3/-call/enqueue.html)
-- `ok_http` can now send asynchronous requests
+- `ok_http` can now send asynchronous requests and stream response bodies.
+- Add [DevTools Network View](https://docs.flutter.dev/tools/devtools/network) support.

pkgs/ok_http/android/src/main/kotlin/com/example/ok_http/RedirectInterceptor.kt

@@ -11,8 +11,19 @@ package com.example.ok_http
 
 import okhttp3.Interceptor
 import okhttp3.OkHttpClient
+import okhttp3.Response
 import java.io.IOException
 
+/**
+ * Callback interface utilized by the [RedirectInterceptor].
+ *
+ * Allows Dart code to operate upon the intermediate redirect responses.
+ */
+interface RedirectReceivedCallback {
+    fun onRedirectReceived(response: Response, location: String)
+}
+
+
 class RedirectInterceptor {
     companion object {
 
@@ -26,7 +37,10 @@ class RedirectInterceptor {
          * @return OkHttpClient.Builder
          */
         fun addRedirectInterceptor(
-            clientBuilder: OkHttpClient.Builder, maxRedirects: Int, followRedirects: Boolean
+            clientBuilder: OkHttpClient.Builder,
+            maxRedirects: Int,
+            followRedirects: Boolean,
+            redirectCallback: RedirectReceivedCallback,
         ): OkHttpClient.Builder {
             return clientBuilder.addInterceptor(Interceptor { chain ->
                 var req = chain.request()
@@ -39,6 +53,9 @@ class RedirectInterceptor {
                     }
 
                     val location = response.header("location") ?: break
+
+                    redirectCallback.onRedirectReceived(response, location)
+
                     req = req.newBuilder().url(location).build()
                     response.close()
                     response = chain.proceed(req)