Merge remote-tracking branch 'upstream/master' into web-configuration

dart-lang · Nov 2, 2023 · b69aeb9 · b69aeb9
2 parents aa22608 + a2f3c1d
commit b69aeb9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/pkgs/cronet_http/CHANGELOG.md b/pkgs/cronet_http/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.4.1
+
+* Require `package:jni >= 0.7.1` so that depending on `package:cronet_http` 
+  does not break macOS builds.
+
+* Fix obsolete `CronetClient()` constructor usage.
+
 ## 0.4.0
 
 * Use more efficient operations when copying bytes between Java and Dart.

diff --git a/pkgs/cronet_http/lib/cronet_http.dart b/pkgs/cronet_http/lib/cronet_http.dart
@@ -10,7 +10,7 @@
 /// import 'package:cronet_http/cronet_http.dart';
 ///
 /// void main() async {
-///   var client = CronetClient();
+///   var client = CronetClient.defaultCronetEngine();
 ///   final response = await client.get(
 ///       Uri.https('www.googleapis.com', '/books/v1/volumes', {'q': '{http}'}));
 ///   if (response.statusCode != 200) {

diff --git a/pkgs/cronet_http/lib/src/cronet_client.dart b/pkgs/cronet_http/lib/src/cronet_client.dart
@@ -235,7 +235,7 @@ jb.UrlRequestCallbackProxy_UrlRequestCallbackInterface _urlRequestCallbacks(
 /// For example:
 /// ```
 /// void main() async {
-///   var client = CronetClient();
+///   var client = CronetClient.defaultCronetEngine();
 ///   final response = await client.get(
 ///       Uri.https('www.googleapis.com', '/books/v1/volumes', {'q': '{http}'}));
 ///   if (response.statusCode != 200) {

diff --git a/pkgs/cronet_http/pubspec.yaml b/pkgs/cronet_http/pubspec.yaml
@@ -1,7 +1,7 @@
 name: cronet_http
 description: >
   An Android Flutter plugin that provides access to the Cronet HTTP client.
-version: 0.4.0
+version: 0.4.1
 repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http
 
 environment:
@@ -12,7 +12,7 @@ dependencies:
   flutter:
     sdk: flutter
   http: '>=0.13.4 <2.0.0'
-  jni: ^0.7.0
+  jni: ^0.7.1
 
 dev_dependencies:
   dart_flutter_team_lints: ^1.0.0