Skip to content

Commit

Permalink
Renable cached images
Browse files Browse the repository at this point in the history
  • Loading branch information
brianquinlan committed Sep 7, 2023
1 parent 27f4282 commit c1779f1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/cronet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ jobs:
java-version: '17'
- uses: subosito/flutter-action@v2
with:
# TODO: Change to 'stable' when a release version of flutter
# pins version 1.21.1 or later of 'package:test'
channel: 'master'
channel: 'stable'
- name: Run tests
uses: reactivecircus/android-emulator-runner@v2
with:
Expand Down
6 changes: 3 additions & 3 deletions pkgs/cronet_http/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'dart:convert';
import 'dart:io';

// import 'package:cached_network_image/cached_network_image.dart';
import 'package:cached_network_image/cached_network_image.dart';
import 'package:cronet_http/cronet_http.dart';
import 'package:flutter/material.dart';
import 'package:http/http.dart';
Expand Down Expand Up @@ -124,10 +124,10 @@ class _BookListState extends State<BookList> {
itemBuilder: (context, index) => Card(
key: ValueKey(widget.books[index].title),
child: ListTile(
/* leading: CachedNetworkImage(
leading: CachedNetworkImage(
placeholder: (context, url) =>
const CircularProgressIndicator(),
imageUrl: widget.books[index].imageUrl),*/
imageUrl: widget.books[index].imageUrl),
title: Text(widget.books[index].title),
subtitle: Text(widget.books[index].description),
),
Expand Down
2 changes: 1 addition & 1 deletion pkgs/cronet_http/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
sdk: ">=2.19.0 <3.0.0"

dependencies:
# cached_network_image: ^3.2.3
cached_network_image: ^3.2.3
cronet_http:
path: ../
cupertino_icons: ^1.0.2
Expand Down

0 comments on commit c1779f1

Please sign in to comment.