pkgs/ok_http: Close the client (override close() from BaseClient) (…

…#1224)
dart-lang · Jun 3, 2024 · eb87a60 · eb87a60
1 parent 9f022d2
commit eb87a60
Show file tree

Hide file tree

Showing 4 changed files with 1,349 additions and 9 deletions.
diff --git a/pkgs/ok_http/example/integration_test/client_test.dart b/pkgs/ok_http/example/integration_test/client_test.dart
@@ -19,9 +19,11 @@ Future<void> testConformance() async {
     testResponseBody(OkHttpClient(), canStreamResponseBody: false);
     testRequestHeaders(OkHttpClient());
     testRequestMethods(OkHttpClient(), preservesMethodCase: true);
+    testResponseHeaders(OkHttpClient(), supportsFoldedHeaders: false);
     testResponseStatusLine(OkHttpClient());
     testCompressedResponseBody(OkHttpClient());
     testServerErrors(OkHttpClient());
+    testClose(OkHttpClient.new);
     testIsolate(OkHttpClient.new);
     testResponseCookies(OkHttpClient(), canReceiveSetCookieHeaders: true);
   });

diff --git a/pkgs/ok_http/jnigen.yaml b/pkgs/ok_http/jnigen.yaml
@@ -23,6 +23,9 @@ classes:
   - "okhttp3.Call"
   - "okhttp3.Headers"
   - "okhttp3.Callback"
+  - "okhttp3.ConnectionPool"
+  - "okhttp3.Dispatcher"
+  - "okhttp3.Cache"
 
 # Exclude the deprecated methods listed below
 # They cause syntax errors during the `dart format` step of JNIGen.
@@ -76,6 +79,8 @@ exclude:
     - 'okhttp3.OkHttpClient\$Builder#-addNetworkInterceptor'
     - 'okhttp3.Headers\$Companion#-deprecated_of'
     - "okhttp3.Headers#-deprecated_size"
+    - "okhttp3.Dispatcher#-deprecated_executorService"
+    - "okhttp3.Cache#-deprecated_directory"
 
 class_path:
   - "jar/okhttp-4.12.0.jar"