-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a skeleton "http_profile" package #1036
Add a skeleton "http_profile" package #1036
Conversation
|
||
/// Records information about an HTTP request. | ||
final class HttpClientRequestProfile { | ||
/// Determines whether HTTP profiling is enabled or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Avoid phrases for getters. For booleans we often start the doc with "Whether".
/// Determines whether HTTP profiling is enabled or not. | |
/// Whether HTTP profiling is enabled for the current zone's [HttpClient]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to pull the zone concept in here - I think that this is actually per isolate. But I stared the sentence with "Whether".
static set profilingEnabled(bool enabled) => | ||
HttpClient.enableTimelineLogging = enabled; | ||
|
||
String? requestMethod; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand the commit message (I usually edit the first PR comment then copy it to the message when I squash/merge) to include more details about how this class will be used by the SDK/DevTools?
What code will fill these fields in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the commit message.
Co-authored-by: Nate Bosch <[email protected]>
…to http_profile_create
Co-authored-by: Nate Bosch <[email protected]>
package:http_profile
(final name TBD)HttpClientRequestProfile
instance and have that information displayed in the DevTools Network tab)Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.