Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require package:jni >= 0.7.1 to fix macOS build #1041

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

brianquinlan
Copy link
Collaborator

  • package:jni 0.7.0 required jni headers to be present, which they may not be on macOS. This broke the macOS build for any flutter app depending on package:cronet_http, even though package:cronet_http is not used on macOS

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianquinlan brianquinlan merged commit a2f3c1d into dart-lang:master Nov 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants