Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cronet_http requests method #1054

Closed
wants to merge 4 commits into from

Conversation

AlexV525
Copy link
Contributor

Fixes #1053.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@AlexV525 AlexV525 marked this pull request as ready for review November 24, 2023 16:28
@AlexV525
Copy link
Contributor Author

@brianquinlan

@kevmoo kevmoo requested a review from brianquinlan November 25, 2023 20:40
@brianquinlan
Copy link
Collaborator

I've incorporated your change into #1058 - thanks for the PR!

@AlexV525 AlexV525 deleted the fix/cronet-request-method branch November 29, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CronetClient didn't setup proper method for requests
2 participants