Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard code the embedded cronet version #1101

Closed
wants to merge 3 commits into from
Closed

Hard code the embedded cronet version #1101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23b50ab
Hard code the embedded cronet version
brianquinlan Jan 2, 2024
ffa890e
Single quotes
brianquinlan Jan 2, 2024
25df744
Update prepare_for_embedded.dart
brianquinlan Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 21 additions & 29 deletions pkgs/cronet_http/tool/prepare_for_embedded.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,25 @@ library;

import 'dart:io';

import 'package:http/http.dart' as http;
import 'package:xml/xml.dart';
import 'package:yaml_edit/yaml_edit.dart';

late final Directory _packageDirectory;

// For the latest version, see:
// https://mvnrepository.com/artifact/org.chromium.net/cronet-embedded
const _cronetEmbeddedVersion = '113.5672.61';
const _gmsDependencyName = 'com.google.android.gms:play-services-cronet';
const _embeddedDependencyName = 'org.chromium.net:cronet-embedded';
const _packageName = 'cronet_http_embedded';
const _packageDescription = 'An Android Flutter plugin that '
'provides access to the Cronet HTTP client. '
'Identical to package:cronet_http except that it embeds Cronet '
'rather than relying on Google Play Services.';
final _cronetVersionUri = Uri.https(
'dl.google.com',
'android/maven2/org/chromium/net/group-index.xml',
final implementationRegExp = RegExp(
'^\\s*implementation [\'"]'
'$_gmsDependencyName'
':\\d+.\\d+.\\d+[\'"]',
multiLine: true,
);

void main(List<String> args) async {
Expand All @@ -50,40 +53,18 @@ void main(List<String> args) async {
_packageDirectory = Directory.current;
}

final latestVersion = await _getLatestCronetVersion();
updateCronetDependency(latestVersion);
updateCronetDependency(_cronetEmbeddedVersion);
update2();
updatePubSpec();
updateReadme();
updateLibraryName();
updateImports();
}

Future<String> _getLatestCronetVersion() async {
final response = await http.get(_cronetVersionUri);
final parsedXml = XmlDocument.parse(response.body);
final embeddedNode = parsedXml.children
.singleWhere((e) => e is XmlElement)
.children
.singleWhere((e) => e is XmlElement && e.name.local == 'cronet-embedded');
final stableVersionReg = RegExp(r'^\d+.\d+.\d+$');
final versions = embeddedNode.attributes
.singleWhere((e) => e.name.local == 'versions')
.value
.split(',')
.where((e) => stableVersionReg.stringMatch(e) == e);
return versions.last;
}

/// Update android/build.gradle.
void updateCronetDependency(String latestVersion) {
final fBuildGradle = File('${_packageDirectory.path}/android/build.gradle');
final gradleContent = fBuildGradle.readAsStringSync();
final implementationRegExp = RegExp(
'^\\s*implementation [\'"]'
'$_gmsDependencyName'
':\\d+.\\d+.\\d+[\'"]',
multiLine: true,
);
final newImplementation = '$_embeddedDependencyName:$latestVersion';
print('Patching $newImplementation');
final newGradleContent = gradleContent.replaceAll(
Expand All @@ -93,6 +74,17 @@ void updateCronetDependency(String latestVersion) {
fBuildGradle.writeAsStringSync(newGradleContent);
}

void update2() {
final fBuildGradle =
File('${_packageDirectory.path}/example/android/app/build.gradle');
final gradleContent = fBuildGradle.readAsStringSync();
final newGradleContent = gradleContent.replaceAll(
implementationRegExp,
'',
);
fBuildGradle.writeAsStringSync(newGradleContent);
}

/// Update pubspec.yaml and example/pubspec.yaml.
void updatePubSpec() {
print('Updating pubspec.yaml');
Expand Down
Loading