Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken PR:( #1421

Closed
wants to merge 457 commits into from
Closed

Broken PR:( #1421

wants to merge 457 commits into from

Conversation

snoopdoggy322
Copy link

This merge request addresses a long-standing issue (#175) where the http package defaults to latin1 encoding when no charset is specified in the Content-Type header. Per RFC 8259, the default encoding for application/json should be utf-8.

The fix ensures that responses with Content-Type: application/json and no explicit charset parameter are decoded using utf8 by default. This change improves compliance with the JSON standard and prevents decoding errors for valid JSON payloads encoded in utf-8.

brianquinlan and others added 30 commits February 27, 2023 12:13
@brianquinlan
Provide access to NSURLSession.sessionDescription (#881)
2583d23
@bahaafathi
Corrected the spelling of "Implements" in "/http/lib/src/io_client.da…
970bef4 
…rt" (#871)

Fixed a spelling error by correcting "Implemenents" to "Implements" in "/http/lib/src/io_client.dart".
@kevmoo
Move to pkg:dart_flutter_team_lints, require Dart 2.19 (#883)
572e10b
@kevmoo
Fix some spelling (#884)
b69493c
@brianquinlan
Fix a reference count race with forwarded delegates. (#888)
90a1093
@brianquinlan
Add a flag to allow the default Client to be tree shaken away. (#868)
85fccfb
@brianquinlan
Add conformances test that verify that the Client works in Isolates (#…
42e9af4 
…889)
@bahaafathi
Fix some spelling (#885)
f3ec6c4
@brianquinlan
Fix maxRedirects documentation to mention ClientException rather than…
a1865c7 
… RedirectException (#907)
@kevmoo
latest CI actions (#908)
527a5cb
@brianquinlan
Document that RetryClient may consume a lot of memory (#915)
77c72e8
@natebosch
Prepare to publish (#914)
5978573
@brianquinlan
Switch to "dart format" from "flutter format" (#922)
3b9a06d 
flutter format is deprecated
@brianquinlan
Add "base", "final" and "interface" modifiers (#920)
1be01f9
@brianquinlan @natebosch
Require the release version of Dart 3.0.0 (#925)
5268329 
* Require the release version of Dart 3.0.0

* Update dart.yml

* Update pkgs/http/pubspec.yaml

Co-authored-by: Nate Bosch <[email protected]>

---------

Co-authored-by: Nate Bosch <[email protected]>
@brianquinlan
Support the NSURLSession WebSocket API (#921)
964d59c
@brianquinlan
Revert "Support the NSURLSession WebSocket API (#921)" (#931)
14914ec 
This reverts commit 981b63b.
@devoncarew
blast_repo fixes (#933)
8916d31 
dependabot
@brianquinlan
Disable package:cupertino_http tests because they are failing at head (…
90db1d1 
…#940)
@brianquinlan
Increment package:http version to 1.0.0 (#928)
db38fe3
@brianquinlan
Update CHANGELOG for 0.2.1 release (#941)
85e3db2
@brianquinlan
Update pubspec for 0.2.1 release (#942)
4f087b9
@brianquinlan
Require Dart 3.0 (#943)
31cdb49
@knaeckeKami
fix typo in cupertino_http documentation (#879)
36df5c5
@AlexV525 @brianquinlan
Update prepare_for_embedded.dart (#944)
4a0e68b 
Co-authored-by: Brian Quinlan <[email protected]>
@devoncarew
regenerate with the latest mono_repo (#947)
255ec4a
@brianquinlan
Add a better toString to _ClientSocketException (#948)
f1387f4
@brianquinlan
Fix the failing cupertino_http tests (#949)
2683703
@brianquinlan
Prepare to publish cupertino_http 1.0.0 (#951)
4ef2fc2
@dependabot
Bump actions/labeler from 4.0.2 to 4.0.4 (#952)
aebd936 
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.0.2 to 4.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.0.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Add and configure ESLint and update configuration for Prettier by <a href="https://github.com/IvanZosimov"><code>@�IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/508">actions/labeler#508</a></li>
<li>Turn on automatic update of ESLint and Prettier configuration files by <a href="https://github.com/IvanZosimov"><code>@�IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/509">actions/labeler#509</a></li>
<li>Automatic update of configuration files from 03/12/2023 by <a href="https://github.com/github-actions"><code>@�github-actions</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/513">actions/labeler#513</a></li>
<li>Bump eslint-config-prettier from 8.6.0 to 8.8.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/520">actions/labeler#520</a></li>
<li>Rebuild minimatch by <a href="https://github.com/panticmilos"><code>@�panticmilos</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/522">actions/labeler#522</a></li>
<li>Bump license version by <a href="https://github.com/panticmilos"><code>@�panticmilos</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/525">actions/labeler#525</a></li>
<li>Fix glob bug in package.json scripts section by <a href="https://github.com/IvanZosimov"><code>@�IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/528">actions/labeler#528</a></li>
<li>Bump prettier from 2.8.7 to 2.8.8 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/544">actions/labeler#544</a></li>
<li>Bump eslint from 8.40.0 to 8.41.0 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/569">actions/labeler#569</a></li>
<li>Bump <code>@�typescript-eslint/parser</code> from 5.59.6 to 5.59.7 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/573">actions/labeler#573</a></li>
<li>Bump <code>@�typescript-eslint/eslint-plugin</code> from 5.59.6 to 5.59.7 by <a href="https://github.com/dependabot"><code>@�dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/572">actions/labeler#572</a></li>
<li>Remove implicit dependencies by <a href="https://github.com/nikolai-laevskii"><code>@�nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/571">actions/labeler#571</a></li>
<li>Automatic update of configuration files from 05/23/2023 by <a href="https://github.com/github-actions"><code>@�github-actions</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/570">actions/labeler#570</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/github-actions"><code>@�github-actions</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/513">actions/labeler#513</a></li>
<li><a href="https://github.com/panticmilos"><code>@�panticmilos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/522">actions/labeler#522</a></li>
<li><a href="https://github.com/nikolai-laevskii"><code>@�nikolai-laevskii</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/571">actions/labeler#571</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.0.4">https://github.com/actions/labeler/compare/v4...v4.0.4</a></p>
<h2>v4.0.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Make the <code>repo-token</code> input optional. Default is <code>github.token</code> (<a href="https://redirect.github.com/actions/labeler/issues/227">#227</a>)</li>
<li>Bump typescript to 4.9.5 (<a href="https://redirect.github.com/actions/labeler/issues/496">#496</a>)</li>
<li>Bump prettier to 2.8.4 (<a href="https://redirect.github.com/actions/labeler/issues/498">#498</a>)</li>
<li>Bump <code>@�vercel/ncc</code> to 0.36.1 (<a href="https://redirect.github.com/actions/labeler/issues/493">#493</a>)</li>
<li>Bump <code>@�actions/github</code>, minimatch and <code>@�types/minimatch</code> (<a href="https://redirect.github.com/actions/labeler/issues/477">#477</a>)</li>
<li>Update documentation (<a href="https://redirect.github.com/actions/labeler/issues/278">#278</a>, <a href="https://redirect.github.com/actions/labeler/issues/285">#285</a>, <a href="https://redirect.github.com/actions/labeler/issues/476">#476</a> and <a href="https://redirect.github.com/actions/labeler/issues/495">#495</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/0776a679364a9a16110aac8d0f40f5e11009e327"><code>0776a67</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/571">#571</a> from akv-platform/remove-implicit-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/2713f7303c96cb1e69627957ec16eea0fd7f94a4"><code>2713f73</code></a> Bump <code>@�typescript-eslint/eslint-plugin</code> from 5.59.6 to 5.59.7 (<a href="https://redirect.github.com/actions/labeler/issues/572">#572</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/a4eda65d3dd04bf2609bd957219885eac0efebdf"><code>a4eda65</code></a> Bump <code>@�typescript-eslint/parser</code> from 5.59.6 to 5.59.7 (<a href="https://redirect.github.com/actions/labeler/issues/573">#573</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/5c4deb8a24f8a41657d61c18894d8e700cdee67a"><code>5c4deb8</code></a> Revert &quot;fix: correct reading of sync-labels input. (<a href="https://redirect.github.com/actions/labeler/issues/480">#480</a>)&quot; (<a href="https://redirect.github.com/actions/labeler/issues/564">#564</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/08382d15cbe3356793d4187dcd9792a2d10cb03c"><code>08382d1</code></a> Move eslint-plugin-node to dev dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/61662e8f41cc6781d48b2fd405c5cd6420128af6"><code>61662e8</code></a> Bump eslint from 8.40.0 to 8.41.0 (<a href="https://redirect.github.com/actions/labeler/issues/569">#569</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/d1dd326cccf2f7c059720fe6ad43b76abd786264"><code>d1dd326</code></a> Install eslint-plugin-node</li>
<li><a href="https://github.com/actions/labeler/commit/91076827ed0d4506993bae4f3cf7aacc578c9a3f"><code>9107682</code></a> Update configuration files</li>
<li><a href="https://github.com/actions/labeler/commit/6b107e7a7ee5e054e0bcce60de5181d21e2f00fb"><code>6b107e7</code></a> Bump <code>@�typescript-eslint/parser</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/565">#565</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/d93c73a681c099c55b461e5ef853f84b8335eebf"><code>d93c73a</code></a> Bump <code>@�typescript-eslint/eslint-plugin</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/566">#566</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/5c7539237e04b714afd8ad9b4aed733815b9fab4...0776a679364a9a16110aac8d0f40f5e11009e327">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.0.2&new-version=4.0.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
mosuem and others added 17 commits October 18, 2024 10:59
@mosuem
Merge pull request #1319 from dart-lang/merge-http_parser-package
52cb5b9 
Merge `package:http_parser`
@mosuem
Merge branch 'master' into merge-http2-package
78fa9b7
@mosuem
Merge pull request #1318 from dart-lang/merge-http2-package
43adbc8 
Merge `package:http2`
@brianquinlan
Replace Objective-C implemented delegates with Dart implementations (#…
3f2ec5a 
…1218)
@brianquinlan
Remove package:java_http (#1389)
b88ccb8
@dependabot
Bump the github-actions group across 1 directory with 5 updates (#1392)
8cc9862 
Bumps the github-actions group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `4.1.7` | `4.2.2` |
| [actions/setup-java](https://github.com/actions/setup-java) | `4.2.1` | `4.5.0` |
| [reactivecircus/android-emulator-runner](https://github.com/reactivecircus/android-emulator-runner) | `2.31.0` | `2.33.0` |
| [futureware-tech/simulator-action](https://github.com/futureware-tech/simulator-action) | `3` | `4` |
| [actions/cache](https://github.com/actions/cache) | `4.0.2` | `4.1.2` |



Updates `actions/checkout` from 4.1.7 to 4.2.2
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.7...11bd719)

Updates `actions/setup-java` from 4.2.1 to 4.5.0
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@99b8673...8df1039)

Updates `reactivecircus/android-emulator-runner` from 2.31.0 to 2.33.0
- [Release notes](https://github.com/reactivecircus/android-emulator-runner/releases)
- [Changelog](https://github.com/ReactiveCircus/android-emulator-runner/blob/main/CHANGELOG.md)
- [Commits](ReactiveCircus/android-emulator-runner@77986be...62dbb60)

Updates `futureware-tech/simulator-action` from 3 to 4
- [Release notes](https://github.com/futureware-tech/simulator-action/releases)
- [Changelog](https://github.com/futureware-tech/simulator-action/blob/main/CHANGELOG.md)
- [Commits](futureware-tech/simulator-action@bfa03d9...dab10d8)

Updates `actions/cache` from 4.0.2 to 4.1.2
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0c45773...6849a64)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: reactivecircus/android-emulator-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: futureware-tech/simulator-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@brianquinlan
Switch to http_image_provider 1.0 (#1391)
c9cb9ac
@brianquinlan
Prepare to publish cupertino_http 2.0.0 (#1390)
d37f112
@kevmoo
Drop outdated lint (#1395)
7fb131e
@brianquinlan
Fix a bug where cupertino_http did not work on iOS<17. (#1399)
bcd07ab 
- Fixes #1398
@brianquinlan
Release package:cupertino_http 2.0.1 (#1400)
4e031e1
@brianquinlan
Upgrade flutter_http_example to cupertino_http (#1393)
4e49aed
@brianquinlan
Add macOS tests for package:cupertino_http (#1403)
f10ed1a
@mraleph
Switch browser_client.dart to use fetch (#1401)
bf2fce2 
Issue #595
@brianquinlan
Upgrade to package:objective_c` 4.0 (#1406)
fde0878
@brianquinlan
Include names in argument lists (#1408)
9226c60
@brianquinlan
Upgrade ok_http to jnigen 0.12.2 (#1405)
e91be50
@google-cla Google CLA
Copy link

google-cla bot commented Dec 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@snoopdoggy322
Copy link
Author

closing as broken brach, sorry

@snoopdoggy322 snoopdoggy322 changed the title Fix Default Encoding for application/json Content-Type in HTTP Responses Broken PR:( Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:cronet_http package:cupertino_http Issues related to package:cupertino_http package:http_client_conformance_tests package:http_parser package:http package:http2 type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.