Fix bug in ObjectMetadata.replace -- release gcloud (#187)

dart-lang · Nov 11, 2024 · 020a6a1 · 020a6a1
1 parent 3740cf5
commit 020a6a1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/pkgs/gcloud/CHANGELOG.md b/pkgs/gcloud/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.8.17
+ - Fix bug in `ObjectMetadata.replace` where  `contentEncoding` overwrote
+   `contentDisposition` and `contentLanguage`.
+
 ## 0.8.16
 
  - `BucketEntry` is now `sealed` this may cause **breakage** for anyone

diff --git a/pkgs/gcloud/lib/src/storage_impl.dart b/pkgs/gcloud/lib/src/storage_impl.dart
@@ -514,8 +514,8 @@ class _ObjectMetadata implements ObjectMetadata {
         contentType: contentType ?? this.contentType,
         contentEncoding: contentEncoding ?? this.contentEncoding,
         cacheControl: cacheControl ?? this.cacheControl,
-        contentDisposition: contentDisposition ?? this.contentEncoding,
-        contentLanguage: contentLanguage ?? this.contentEncoding,
+        contentDisposition: contentDisposition ?? this.contentDisposition,
+        contentLanguage: contentLanguage ?? this.contentLanguage,
         custom: custom != null ? Map.from(custom) : this.custom);
   }
 }

diff --git a/pkgs/gcloud/pubspec.yaml b/pkgs/gcloud/pubspec.yaml
@@ -1,5 +1,5 @@
 name: gcloud
-version: 0.8.16
+version: 0.8.17
 description: >-
   High level idiomatic Dart API for Google Cloud Storage, Pub-Sub and Datastore.
 repository: https://github.com/dart-lang/labs/tree/main/pkgs/gcloud