-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_toolchain_c] Support ld.ldd
as linker on Linux
#1468
Conversation
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
LGTM!
This PR passes |
Closes: #1460
ld.lld
instead of the GCC linker on the Dart SDK CI)-f
means forward to linker, but if we invoke linker directly, we don't need that.Testing:
ld.ldd
on the GitHub CI, so we can't run a unit test here.ProcessManager
andFileSystem
#90readelf
ld.lld
by patching pkgs/native_toolchain_c/lib/src/cbuilder/compiler_resolver.dart to preferlld
overx86_64LinuxGnuLd
.