Update all lints and dart_flutter_team_lints dependencies
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
reviewed
Oct 27, 2023
| @@ -33,8 +33,8 @@ class BuildOutput { | |||
| Metadata? metadata, | |||
| }) : timestamp = (timestamp ?? DateTime.now()).roundDownToSeconds(), | |||
| assets = assets ?? [], | |||
| dependencies = dependencies ?? Dependencies([]), | |||
| metadata = metadata ?? Metadata({}); | |||
| dependencies = dependencies ?? const Dependencies([]), | |||
There was a problem hiding this comment.
It seems that this leads to unmodifiable lists trying to get modified:
https://github.com/dart-lang/native/actions/runs/6665614043/job/18115686857?pr=167
|
@parlough it seems we're running into unmodifiable list errors being thrown in various places because the default values for arguments are now not modifiable. Could you please submit a PR to make the defaults modifiable again (and test it with unit tests). I'm not sure why this was not caught by the CI earlier. 🙈 |
This was referenced Oct 27, 2023
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package:dart_flutter_team_lintsandpackage:lints.analysis_options.yamlfiles