[native_toolchain_c] Use sysroot on Android #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
rmacnak-google
approved these changes
Nov 1, 2023
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Bumps [egor-tensin/setup-clang](https://github.com/egor-tensin/setup-clang) from 1.3 to 1.4. - [Release notes](https://github.com/egor-tensin/setup-clang/releases) - [Commits](egor-tensin/setup-clang@01d437c...ef434b4) --- updated-dependencies: - dependency-name: egor-tensin/setup-clang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Bumps [egor-tensin/setup-clang](https://github.com/egor-tensin/setup-clang) from 1.3 to 1.4. - [Release notes](https://github.com/egor-tensin/setup-clang/releases) - [Commits](egor-tensin/setup-clang@01d437c...ef434b4) --- updated-dependencies: - dependency-name: egor-tensin/setup-clang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Addresses: #165 (comment) This is in line with what CMake does, so it's probably a more reasonable thing to do than `-nostartfiles`. The documentation says the sysroot should be auto-discovered on NDKs newer than 22, but it doesn't seem to break the newer versions, so maybe lets just keep the logic consistent for various NDK versions. We probably need a workaround for #165 temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #165 (comment)
This is in line with what CMake does, so it's probably a more reasonable thing to do than
-nostartfiles.The documentation says the sysroot should be auto-discovered on NDKs newer than 22, but it doesn't seem to break the newer versions, so maybe lets just keep the logic consistent for various NDK versions.
We probably need a workaround for #165 temporarily.