[native_assets_cli] Drop Config
suffixes v1
#1829
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
BuildConfig.targetOS
toBuildConfig.codeConfig.targetOS
, remove it entirely or extend to cover web #1738 (comment)A variant of:
Config
suffixes v2 #1830This PR normalizes the
code
anddata
specific APIs on the config, config builder, output and output builders under a.code
and.data
extension. Except for theassets
, the are available underconfig/output.assets.code
andconfig/output.assets.data
.Example link hook code:
Example build hook code:
This drops
Config
suffixes from the various config accessors.This changes
output.codeAssets.add(
tooutput.code.addAsset(
.The weird quirk in this PR is that the list of assets per type is available under
config.assets.code
while all the othercode
related things are available underconfig.code
andoutput.code
. To address this see:Config
suffixes v2 #1830