[native_assets_builder] Try fix Flutter roll #1848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosuem
approved these changes
Jan 2, 2025
|
This unfortunately doesn't fix the issue #1847 (comment) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #1847.
It's impossible to test if this fix works without releasing a new version unfortunately. It doesn't reproduce for me locally, and the CI on Flutter doesn't work with git dependencies.
The only git commands I can find in the various
.batscripts are usingFLUTTER_ROOT. And the invocation of the Dart executable is failing with a git error and git exit code. So it must be the wrapper script arounddart.exethat's crashing.The proper fix would be to let Flutter pass in the environment with
FLUTTER_ROOT, but for now I simply want to unstuck the Flutter roll first.