[native_assets_builder] Make hook environment configurable #1853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the environment used to invoke hooks configurable.
The flutter roll is failing currently, and I suspect it has to do with our change to tie down the environment variables. The execution of the
dart
executable fails. #1847We can't easily troubleshoot which env key is missing currently, because the environment is not configurable from the embedder.
Since we'd like the embedder to be able to configure the environment anyways (e.g. Flutter might want to pass in
ANDROID_HOME
but Dart not), make the change now.Hopefully, we can then trouble-shoot what's going on. (At the very least we can try passing the full environment in flutter_tools to see if that fixes the issue.)