Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_builder] Make hook environment configurable #1853

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jan 2, 2025

Make the environment used to invoke hooks configurable.

The flutter roll is failing currently, and I suspect it has to do with our change to tie down the environment variables. The execution of the dart executable fails. #1847

We can't easily troubleshoot which env key is missing currently, because the environment is not configurable from the embedder.

Since we'd like the embedder to be able to configure the environment anyways (e.g. Flutter might want to pass in ANDROID_HOME but Dart not), make the change now.

Hopefully, we can then trouble-shoot what's going on. (At the very least we can try passing the full environment in flutter_tools to see if that fixes the issue.)

Copy link

github-actions bot commented Jan 2, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:native_assets_builder 0.10.1 ready to publish native_assets_builder-v0.10.1
package:ffi 2.1.3 already published at pub.dev
package:ffigen 16.0.1-wip WIP (no publish necessary)
package:jni 0.13.0 already published at pub.dev
package:jnigen 0.13.0 already published at pub.dev
package:native_assets_cli 0.10.0 already published at pub.dev
package:native_toolchain_c 0.7.0 already published at pub.dev
package:objective_c 4.0.1-wip WIP (no publish necessary)
package:swift2objc 0.0.1-wip WIP (no publish necessary)
package:swiftgen 0.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dcharkes dcharkes requested a review from mosuem January 2, 2025 09:57
@dcharkes dcharkes merged commit 2251646 into main Jan 2, 2025
23 checks passed
@dcharkes dcharkes deleted the pass-in-env-hook branch January 2, 2025 10:05
@coveralls
Copy link

Coverage Status

coverage: 87.527% (+0.001%) from 87.526%
when pulling 3ca37a6 on pass-in-env-hook
into 0495080 on main.

auto-submit bot pushed a commit that referenced this pull request Jan 2, 2025
The health workflow is disabled currently, and #1853 accidentally hid too many public types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants