Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_toolchain_c] Support environment for cl.exe already set up #1876

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jan 9, 2025

We'd like flutter_tools to invoke the hook/build.dart with the environment for cl.exe already set up and stop passing in input.config.code.cCompiler.envScript.

Therefore, package:native_toolchain_c should not go search for an vcvars batch script if the compiler has been provided in the code config but a vcvars script has not been provided.

Issue:

Copy link

github-actions bot commented Jan 9, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes requested a review from mkustermann January 9, 2025 10:21
@dcharkes dcharkes merged commit 9c07864 into main Jan 9, 2025
33 checks passed
@dcharkes dcharkes deleted the toolchain-env-vars branch January 9, 2025 11:21
@coveralls
Copy link

coveralls commented Jan 9, 2025

Coverage Status

coverage: 87.728% (+0.01%) from 87.717%
when pulling 03e1851 on toolchain-env-vars
into a646680 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants