Skip to content

Commit

Permalink
Also add @doNotSubmit to scaffolding.dart. (#2208)
Browse files Browse the repository at this point in the history
* Also add doNotSubmit to scaffolding.dart.

* Versions and changelog

---------

Co-authored-by: Nate Bosch <[email protected]>
  • Loading branch information
matanlurey and natebosch authored Apr 9, 2024
1 parent 14d820f commit c7a76b0
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 6 deletions.
4 changes: 4 additions & 0 deletions pkgs/test/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.25.4

* Add `@doNotSubmit` to more declarations of the `solo` parameter.

## 1.25.3

* Remove outdated StreamMatcher link from README table of contents.
Expand Down
4 changes: 2 additions & 2 deletions pkgs/test/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test
version: 1.25.3
version: 1.25.4
description: >-
A full featured library for writing and running Dart tests across platforms.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test
Expand Down Expand Up @@ -35,7 +35,7 @@ dependencies:

# Use an exact version until the test_api and test_core package are stable.
test_api: 0.7.1
test_core: 0.6.1
test_core: 0.6.2

typed_data: ^1.3.0
web_socket_channel: ^2.0.0
Expand Down
4 changes: 4 additions & 0 deletions pkgs/test_core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.2

* Add `@doNotSubmit` to more declarations of the `solo` parameter.

## 0.6.1

* Handle missing package configs.
Expand Down
8 changes: 5 additions & 3 deletions pkgs/test_core/lib/src/scaffolding.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import 'dart:async';

import 'package:meta/meta.dart' show isTest, isTestGroup;
import 'package:meta/meta.dart' show doNotSubmit, isTest, isTestGroup;
import 'package:path/path.dart' as p;
import 'package:test_api/backend.dart';
import 'package:test_api/scaffolding.dart' show Timeout, pumpEventQueue;
Expand Down Expand Up @@ -141,7 +141,8 @@ void test(Object? description, dynamic Function() body,
Object? tags,
Map<String, dynamic>? onPlatform,
int? retry,
@Deprecated('Debug only') bool solo = false}) {
// TODO(https://github.com/dart-lang/test/issues/2205): Remove deprecated.
@Deprecated('Debug only') @doNotSubmit bool solo = false}) {
_declarer.test(description.toString(), body,
testOn: testOn,
timeout: timeout,
Expand Down Expand Up @@ -219,7 +220,8 @@ void group(Object? description, dynamic Function() body,
Object? tags,
Map<String, dynamic>? onPlatform,
int? retry,
@Deprecated('Debug only') bool solo = false}) {
// TODO(https://github.com/dart-lang/test/issues/2205): Remove deprecated.
@Deprecated('Debug only') @doNotSubmit bool solo = false}) {
_declarer.group(description.toString(), body,
testOn: testOn,
timeout: timeout,
Expand Down
2 changes: 1 addition & 1 deletion pkgs/test_core/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_core
version: 0.6.1
version: 0.6.2
description: A basic library for writing tests and running them on the VM.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test_core

Expand Down

0 comments on commit c7a76b0

Please sign in to comment.