Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use secure random number generator #335

Merged
merged 1 commit into from
Apr 4, 2024
Merged

use secure random number generator #335

merged 1 commit into from
Apr 4, 2024

Conversation

danielgrad
Copy link
Contributor

@danielgrad danielgrad commented Mar 22, 2024

Fixes #334

@kevmoo kevmoo requested a review from devoncarew March 22, 2024 19:48
@kevmoo
Copy link
Member

kevmoo commented Mar 22, 2024

Sometimes random is needed to be secure. Sometimes it's needed just for noise. "secure" is more expensive, so we should make sure it's strictly needed.

@kevmoo
Copy link
Member

kevmoo commented Mar 22, 2024

Maybe @brianquinlan has an idea, too.

@kevmoo kevmoo changed the title use secure random number generator (#334) use secure random number generator Mar 22, 2024
@kevmoo
Copy link
Member

kevmoo commented Mar 22, 2024

Ah! See the issue now. Updated description. Thanks!

@brianquinlan
Copy link
Contributor

Could you update CHANGELOG.md and pubspec.yaml?

@kevmoo kevmoo merged commit ced3a37 into dart-lang:master Apr 4, 2024
7 checks passed
@brianquinlan
Copy link
Contributor

@danielgrad Thanks so much for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masking is not cryptographically secure
3 participants