Fix a race when close() called before remote class event delivered #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianquinlan
requested review from
kevmoo and
natebosch
and removed request for
kevmoo
natebosch
approved these changes
Apr 26, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 29, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. http (https://github.com/dart-lang/http/compare/34d7087..e459e5c): e459e5c 2024-04-25 Brian Quinlan Use WebSocketConnectionClosed for operations after WebSocket close (dart-lang/http#1180) 9780081 2024-04-25 Brian Quinlan Make the cupertino_http workflow work after 'macos-latest' upgrade (dart-lang/http#1182) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/b612fc2..b672220): b672220 2024-04-26 Brian Quinlan Fix a race when close() called before remote class event delivered (dart-lang/web_socket_channel#348) Change-Id: Ib8946161d9a2c626339901d4de03e989e81159d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364820 Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
mosuem
pushed a commit
to dart-lang/http
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found in the SDK isolate stress tests:
dart-lang/sdk#55538
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.