Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pixi] Exclude hidden folders from formatting #1821

Closed
wants to merge 1 commit into from
Closed

[pixi] Exclude hidden folders from formatting #1821

wants to merge 1 commit into from

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jun 29, 2024

Otherwise:

✨ Pixi task (lint in default): cmake --build build --target format && black . && isort .
[1/1] /bin/sh CMakeFiles/format-5a20493.sh db459a6990039168
Formatting 988 files... 
Done.
error: cannot format /home/js/dev/dartsim/dart/main/.git/logs/refs/remotes/peci1/dartpy/setup.py: Cannot parse: 1:41: 0000000000000000000000000000000000000000 d98d7e3ba7997d71a4c1ca8f0371d42f415dc6af Jeongseok Lee <[email protected]> 1639865355 -0800  fetch --progress --prune --recurse-submodules=no peci1: storing head

Tested on Ubuntu


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.15.0 milestone Jun 29, 2024
@jslee02 jslee02 enabled auto-merge (squash) June 30, 2024 01:01
@jslee02 jslee02 disabled auto-merge June 30, 2024 01:02
@jslee02 jslee02 closed this Jun 30, 2024
@jslee02 jslee02 deleted the format branch June 30, 2024 01:02
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.57%. Comparing base (8362ec6) to head (b2c4e06).
Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage   61.56%   61.57%           
=======================================
  Files         490      490           
  Lines       46024    46024           
=======================================
+ Hits        28336    28339    +3     
+ Misses      17688    17685    -3     

see 1 file with indirect coverage changes

@jslee02 jslee02 removed this from the DART 6.15.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant