Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-format] Set language standard to C++17 #1822

Closed
wants to merge 1 commit into from

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jun 29, 2024

as the code standard is C++17:

https://github.com/dartsim/dart/blob/main/dart/CMakeLists.txt#L162


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.15.0 milestone Jun 29, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.55%. Comparing base (b2c4e06) to head (94380de).

Files with missing lines Patch % Lines
dart/dynamics/HierarchicalIK.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           format    #1822      +/-   ##
==========================================
- Coverage   61.57%   61.55%   -0.03%     
==========================================
  Files         490      490              
  Lines       46024    46024              
==========================================
- Hits        28339    28329      -10     
- Misses      17685    17695      +10     
Files with missing lines Coverage Δ
dart/common/AspectWithVersion.hpp 37.50% <ø> (ø)
dart/common/Cloneable.hpp 100.00% <ø> (ø)
dart/common/Composite.cpp 86.66% <ø> (ø)
dart/common/Composite.hpp 100.00% <ø> (ø)
dart/common/CompositeJoiner.hpp 100.00% <ø> (ø)
dart/common/EmbeddedAspect.hpp 93.75% <ø> (ø)
dart/common/SpecializedForAspect.hpp 100.00% <ø> (ø)
dart/common/detail/AspectWithVersion.hpp 67.44% <ø> (ø)
dart/common/detail/EmbeddedAspect.hpp 73.11% <ø> (ø)
dart/dynamics/BodyNode.cpp 80.79% <ø> (ø)
... and 27 more

... and 3 files with indirect coverage changes

@jslee02 jslee02 closed this Jun 30, 2024
@jslee02 jslee02 deleted the clang_format_cpp17 branch June 30, 2024 01:02
@jslee02 jslee02 removed this from the DART 6.15.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant