Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nlopt 2.9.0 #1874

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Support nlopt 2.9.0 #1874

merged 1 commit into from
Nov 11, 2024

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 10, 2024

LD_LBFGS_NOCEDAL is removed in 2.9.0: stevengj/nlopt@f4e74eb

This should fix https://github.com/dartsim/dart/actions/runs/11768649754/job/32779651842


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.15.0 milestone Nov 10, 2024
@jslee02 jslee02 force-pushed the nlopt_2.9.0 branch 2 times, most recently from 036d044 to 4de88ef Compare November 11, 2024 01:35
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.55%. Comparing base (4b5b6a8) to head (a23190f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files         490      490           
  Lines       46013    46013           
=======================================
  Hits        28325    28325           
  Misses      17688    17688           
Files with missing lines Coverage Δ
dart/optimizer/nlopt/NloptSolver.cpp 25.47% <ø> (ø)
python/dartpy/optimizer/NloptSolver.cpp 87.50% <ø> (ø)

@jslee02 jslee02 merged commit ad50867 into main Nov 11, 2024
34 checks passed
@jslee02 jslee02 deleted the nlopt_2.9.0 branch November 11, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant