feat: Add time value type

[benjamingeer]

This adds a new value type, knora-base:TimeValue, which stores an xsd:dateTime (represented as xsd:dateTimeStamp in API v2).

• Add TimeValue to knora-base and salsah-gui.
• Support knora-base:TimeValue in SPARQL templates:
  • in API v1
  • in API v2
• Support time values in API v1:
  • reading
  • writing
  • bulk import
  • extended search
• Support time values in API v2:
  • reading
  • writing
  • Gravsearch
• Update tests.
  • ValuesResponderV1Spec
  • ValuesV1R2RSpec
  • ResourcesV1R2RSpec
  • ValuesResponderV2Spec
  • ValuesRouteV2E2ESpec
  • OntologyV2R2RSpec
    • Update RDF4J library (fixes stack overflow error).
  • OntologyResponderV2Spec
  • SearchV1R2RSpec
  • SearchRouteV2R2RSpec
  • test data returned for generated client API code
• Add update script plugin.
• Update docs.

Resolves #1397.
Resolves #1446.
Needs dasch-swiss/knora-ui#307.
Needs dasch-swiss/dsp-tools#12.
Needs dasch-swiss/dsp-js-lib#41.

[benjamingeer]

Does StandoffTimeTag have cardinalities for valueHasTimeStamp? Could you compare it to another existing standoff class?

It does, and I did.

:StandoffTimeTag rdf:type owl:Class ;

                        rdfs:subClassOf :StandoffDataTypeTag,
                                        :TimeBase ;

                        rdfs:comment "Represents a timestamp in a TextValue"@en .


:TimeBase rdf:type owl:Class ;

              rdfs:subClassOf :ValueBase ,
                              [ rdf:type owl:Restriction ;
                                owl:onProperty :valueHasTimeStamp ;
                                owl:cardinality "1"^^xsd:nonNegativeInteger
                              ] .


:valueHasTimeStamp rdf:type owl:DatatypeProperty ;

                       rdfs:subPropertyOf :valueHas ;

                       :subjectClassConstraint :TimeBase ;

                       :objectDatatypeConstraint xsd:dateTime .

[tobiasschweizer]

I can try and check this in the afternoon if you want

[benjamingeer]

Yes please. I based the mapping element on the existing one for the date tag, and I can't find anything that looks different.

[benjamingeer]

Found the bug...

[benjamingeer]

Fixed more bugs by adding the test with a standoff timestamp tag (f70fe6c).

[tobiasschweizer]

With which release should this be integrated?

[benjamingeer]

With which release should this be integrated?

It's not going into today's release. It could go into next month's release. Let's talk about this process at tomorrow's meeting.

[tobiasschweizer]

Ok! I would like to assign related PRs in knra-api-js-lib the same milestone tags. This should make it easy to keep track.

[tobiasschweizer]

Can the SALSAH GUI display a time value? Are the value type constants correctly configured?

[benjamingeer]

Can the SALSAH GUI display a time value? Are the value type constants correctly configured?

You mean the old GUI? I guess it can't. Which constants are those?

[tobiasschweizer]

Which constants are those?

I think they are hard-coded in a JS file. They had to be changed to the Knora IRIs. Since the time value hasn't been supported yet by Knora, it is possible that the value type IRI has to be adapted. Maybe @loicjaouen knows this.

[benjamingeer]

OK, I think I've got it working in SALSAH 1 in 68ab4d5. I didn't really know what I was doing, but I can create a resource with a time value, display it, and change the time value. Could you have a look?

[tobiasschweizer]

Could you have a look?

I haven't run it in years. @loicjaouen Could you have a look?

[benjamingeer]

@subotic I'm having trouble finding anyone who can review the changes I made in the SALSAH 1 JavaScript code for this PR. Could you help find a reviewer, or should we just merge it anyway?

[loicjaouen]

sorry, I missed the call, I look at it now

[loicjaouen]

Code looks fine and I tested the timestamp in the GUI, add, edit, store and search work: it behaves as it should

[benjamingeer]

Thanks @loicjaouen !

[benjamingeer]

@tobiasschweizer Is this OK to merge now?

[tobiasschweizer]

I will look at it in a minute!

[tobiasschweizer]

Looks good! When you merge this PR, please also merge dasch-swiss/dsp-js-lib#59. Thanks!

[benjamingeer]

@tobiasschweizer Thank you!