feat!: Remove legacy Sipi upload mechanism (DEV-4260)

[siers]

Removed:

• upload.lua
• AssetIngestState
• doSipiPostUpdate/doSipiPostUpdateIfTemp

[linear]

DEV-4260 Remove feature to ingest assets with Sipi

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.88%. Comparing base (6ebe8e7) to head (f10a5d1).
Report is 127 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3414       +/-   ##
===========================================
- Coverage   83.04%   17.88%   -65.16%     
===========================================
  Files         290      304       +14     
  Lines       23087    22760      -327     
===========================================
- Hits        19172     4071    -15101     
- Misses       3915    18689    +14774     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[seakayone]

I would have expected the org.knora.webapi.routing.v2.AssetIngestState and related code to be removed as well.

This would also include removing the header and updating the documentation.

Are planning to do this in a followup PR?

[siers]

I'll remove it here.

[mpro7]

Shouldn't be some removed tests rewritten to pointing to dsp-ingest?
Also please change the PR prefix to refactor.

[seakayone]

Nice, overall it looks good to me. I have just some minor issues and suggestion

Just a couple of places where you can look into; I have searched for the ingested header and found these:

❯ rg AssetIngested
integration/src/test/scala/org/knora/webapi/it/v2/StandoffRouteV2ITSpec.scala
54:  private val addAssetIngested  = addHeader("X-Asset-Ingested", "true")
332:      ) ~> addCredentials(BasicHttpCredentials(anythingUserEmail, password)) ~> addAssetIngested

integration/src/test/scala/org/knora/webapi/it/v2/KnoraSipiIntegrationV2ITSpec.scala
67:  private val addAssetIngested = addHeader("X-Asset-Ingested", "true")
331:    getResponseJsonLD(request ~> addAuthorization ~> addAssetIngested)
❯ rg Asset-Ingested
CHANGELOG.md
341:* X-Asset-Ingested: skip Sipi temp move for updates (DEV-3504) ([#3219](https://github.com/dasch-swiss/dsp-api/issues/3219)) ([8cf4e9d](https://github.com/dasch-swiss/dsp-api/commit/8cf4e9dc5c93261179c1e6fa927448e84899a67f))

docs/03-endpoints/api-v2/editing-values.md
307:it is necessary to send the header `X-Asset-Ingested`

integration/src/test/scala/org/knora/webapi/e2e/v2/ValuesV2R2RSpec.scala
132:      val header = addHeader("X-Asset-Ingested", "true")

integration/src/test/scala/org/knora/webapi/it/v2/StandoffRouteV2ITSpec.scala
54:  private val addAssetIngested  = addHeader("X-Asset-Ingested", "true")
99:    ) ~> addHeader("X-Asset-Ingested", "true")

integration/src/test/scala/org/knora/webapi/it/v2/KnoraSipiIntegrationV2ITSpec.scala
67:  private val addAssetIngested = addHeader("X-Asset-Ingested", "true")

[seakayone]

Shouldn't be some removed tests rewritten to pointing to dsp-ingest? Also please change the PR prefix to refactor.

Technically this is a breaking change and not a refactor. I would suggest feat!: Remove upload to Sipi and replace with dsp-ingest