Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support json ld for create resource #3420

Merged
merged 17 commits into from
Nov 12, 2024
Merged

feat: Support json ld for create resource #3420

merged 17 commits into from
Nov 12, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 11, 2024 •
edited
Loading

  • add updateValueV2fromJsonLd to ApiComplexV2JsonLdRequestParser
  • implement newValueVersionIri
  • fixuup
  • use json ld for create resource

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title feat/support json ld for create resource feat: Support json ld for create resource Nov 11, 2024
@seakayone seakayone force-pushed the feat/support-json-ld-for-create-resource branch from 1bd3caa to b413bf7 Compare November 11, 2024 15:18
@seakayone seakayone marked this pull request as ready for review November 11, 2024 18:49
mpro7
mpro7 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks! Didn't I already review part of the changes yesterday?

webapi/src/main/scala/org/knora/webapi/slice/common/ApiComplexV2JsonLdRequestParser.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/common/ApiComplexV2JsonLdRequestParser.scala Outdated Show resolved Hide resolved
seakayone and others added 2 commits November 12, 2024 10:54
@seakayone @mpro7
Update webapi/src/main/scala/org/knora/webapi/slice/common/ApiComplex…
111b504 
…V2JsonLdRequestParser.scala

Co-authored-by: Marcin Procyk <[email protected]>
@seakayone @mpro7
Update webapi/src/main/scala/org/knora/webapi/slice/common/ApiComplex…
36828fd 
…V2JsonLdRequestParser.scala

Co-authored-by: Marcin Procyk <[email protected]>
@seakayone seakayone enabled auto-merge (squash) November 12, 2024 09:54
@seakayone seakayone merged commit 419c74d into main Nov 12, 2024
9 checks passed
@seakayone seakayone deleted the feat/support-json-ld-for-create-resource branch November 12, 2024 10:16
@daschbot daschbot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @mpro7