Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add license and copyright attribution fallback (DEV-4352) #3433

Merged
merged 31 commits into from
Nov 27, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 20, 2024

  • Add copyright attribution and license fallback from Project to creating/updating resources and values if not present and not provided by the request
  • this adds Monocle as library, which makes it easier to access and transform immutable data using optics, e.g. lenses in Scala

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title feat/add license and copyright attribution fallback feat: Add license and copyright attribution fallback (DEV-4352) Nov 20, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 73.95833% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (6ebe8e7) to head (c6ef23b).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
...esponder/valuemessages/ValueMessagesV2Optics.scala 44.82% 16 Missing ⚠️
.../org/knora/webapi/slice/common/jena/ModelOps.scala 42.85% 4 Missing ⚠️
...knora/webapi/responders/v2/ValuesResponderV2.scala 86.95% 3 Missing ⚠️
...er/resourcemessages/ResourceMessagesV2Optics.scala 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   83.04%   82.67%   -0.37%     
==========================================
  Files         290      310      +20     
  Lines       23087    22886     -201     
==========================================
- Hits        19172    18921     -251     
- Misses       3915     3965      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@seakayone seakayone force-pushed the feat/add-license-and-copyright-attribution-fallback branch 2 times, most recently from f97e3e5 to c6ef23b Compare November 24, 2024 19:10
@seakayone seakayone force-pushed the feat/add-license-and-copyright-attribution-fallback branch from dd39922 to b514744 Compare November 25, 2024 13:19
@seakayone seakayone marked this pull request as ready for review November 26, 2024 12:39
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The optics in Scala are rather verbose, but sometimes better than not having them at all.

@seakayone seakayone merged commit 0a726e9 into main Nov 27, 2024
8 of 9 checks passed
@seakayone seakayone deleted the feat/add-license-and-copyright-attribution-fallback branch November 27, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants