refactor: remove unused code (#2137)

dasch-swiss · Feb 26, 2025 · 6c9d1b0 · 6c9d1b0
1 parent 097b620
commit 6c9d1b0
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 85 deletions.
diff --git a/libs/vre/pages/ontology/ontology-classes/src/lib/list-view/list-view.component.ts b/libs/vre/pages/ontology/ontology-classes/src/lib/list-view/list-view.component.ts
@@ -110,8 +110,7 @@ export class ListViewComponent implements OnChanges, OnInit, OnDestroy {
               this.initSearch();
             });
         }
-      }),
-      this._componentCommsService.on([Events.resourceDeleted], () => this.doSearch())
+      })
     );
   }
 

diff --git a/libs/vre/resource-editor/representations/src/lib/audio/audio-more-button.component.ts b/libs/vre/resource-editor/representations/src/lib/audio/audio-more-button.component.ts
@@ -30,7 +30,7 @@ import { ResourceUtil } from '../resource.util';
     <mat-menu #more="matMenu" class="representation-menu">
       <button mat-menu-item (click)="openIIIFnewTab()">Open audio in new tab</button>
       <button mat-menu-item [cdkCopyToClipboard]="src.fileValue.fileUrl">Copy audio URL to clipboard</button>
-      <button mat-menu-item (click)="download(src.fileValue.fileUrl)">Download audio</button>
+      <button mat-menu-item (click)="download()">Download audio</button>
       <button mat-menu-item [disabled]="!userCanEdit" (click)="openReplaceFileDialog()">Replace file</button>
     </mat-menu>`,
 })
@@ -75,7 +75,7 @@ export class AudioMoreButtonComponent {
     window.open(this.src.fileValue.fileUrl, '_blank');
   }
 
-  download(url: string) {
+  download() {
     this._rs.downloadProjectFile(this.src.fileValue, this.parentResource);
   }
 

diff --git a/libs/vre/resource-editor/representations/src/lib/audio/audio-player.service.ts b/libs/vre/resource-editor/representations/src/lib/audio/audio-player.service.ts
diff --git a/...esource-editor/representations/src/lib/replace-file-form/replace-file-form.component.html b/...esource-editor/representations/src/lib/replace-file-form/replace-file-form.component.html
diff --git a/libs/vre/resource-editor/representations/src/lib/still-image/still-image.component.ts b/libs/vre/resource-editor/representations/src/lib/still-image/still-image.component.ts
@@ -10,14 +10,9 @@ import {
   SimpleChanges,
   ViewChild,
 } from '@angular/core';
-import { Constants, ReadProject, ReadResource, ReadStillImageFileValue } from '@dasch-swiss/dsp-js';
+import { Constants, ReadResource, ReadStillImageFileValue } from '@dasch-swiss/dsp-js';
 import { ReadStillImageExternalFileValue } from '@dasch-swiss/dsp-js/src/models/v2/resources/values/read/read-file-value';
 import { AppError } from '@dasch-swiss/vre/core/error-handler';
-import { ResourceSelectors } from '@dasch-swiss/vre/core/state';
-import { Store } from '@ngxs/store';
-import { Observable } from 'rxjs';
-import { map } from 'rxjs/operators';
-import { RepresentationService } from '../representation.service';
 import { IIIFUrl } from '../third-party-iiif/third-party-iiif';
 import { OpenSeaDragonService } from './open-sea-dragon.service';
 import { OsdDrawerService } from './osd-drawer.service';
@@ -53,18 +48,10 @@ export class StillImageComponent implements OnChanges, AfterViewInit, OnDestroy
   isViewInitialized = false;
   isPng = false;
 
-  attachedProject$: Observable<ReadProject | undefined> = this._store.select(ResourceSelectors.attachedProjects).pipe(
-    map(attachedProjects => {
-      return this._rs.getParentResourceAttachedProject(attachedProjects, this.resource);
-    })
-  );
-
   constructor(
     private _cdr: ChangeDetectorRef,
     protected osdService: OpenSeaDragonService,
-    private _osdDrawerService: OsdDrawerService,
-    private _store: Store,
-    private _rs: RepresentationService
+    private _osdDrawerService: OsdDrawerService
   ) {}
 
   ngOnChanges(changes: SimpleChanges): void {

diff --git a/libs/vre/shared/app-common-to-move/src/index.ts b/libs/vre/shared/app-common-to-move/src/index.ts
@@ -1,7 +1,6 @@
 export * from './common-to-move.components';
 export * from './lib/dialog-header.component';
 export * from './lib/filtered-resources.interface';
-export * from './lib/gui-cardinality.interface';
 export * from './lib/short-res-info.interface';
 export * from './lib/split.pipe';
 export * from './lib/incoming.service';

diff --git a/libs/vre/shared/app-common-to-move/src/lib/dialog-header.component.ts b/libs/vre/shared/app-common-to-move/src/lib/dialog-header.component.ts
@@ -1,4 +1,4 @@
-import { Component, EventEmitter, Input, Output } from '@angular/core';
+import { Component, Input } from '@angular/core';
 
 @Component({
   selector: 'app-dialog-header',
@@ -18,6 +18,4 @@ import { Component, EventEmitter, Input, Output } from '@angular/core';
 export class DialogHeaderComponent {
   @Input({ required: true }) title!: string;
   @Input() subtitle?: string;
-
-  @Output() closed = new EventEmitter<any>();
 }
diff --git a/libs/vre/shared/app-common-to-move/src/lib/gui-cardinality.interface.ts b/libs/vre/shared/app-common-to-move/src/lib/gui-cardinality.interface.ts
diff --git a/libs/vre/shared/app-helper-services/src/lib/component-communication-event.service.ts b/libs/vre/shared/app-helper-services/src/lib/component-communication-event.service.ts
@@ -41,7 +41,5 @@ export enum Events {
   resourceLanguageChanged,
   loginSuccess,
   gravSearchExecuted,
-  resourceDeleted,
-  resourceChanged,
   unselectedListItem,
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                   this.initSearch();
                 });
             }
-          }),
-          this._componentCommsService.on([Events.resourceDeleted], () => this.doSearch())
+          })
         );
       }
@@ Expand Down @@