This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
chore: Remove unused _*.json metadata #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpro7
reviewed
Jul 26, 2024
Given @danielasubotic approval and the benefits of reducing clutter and improving efficiency, I believe we should proceed with removing these unused files, as they can always be retrieved from version control if needed. |
danielasubotic
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those with a _ are not visible in meta.dasch.swiss. There is code which ignores these files in the service.
I think we should remove them or at least fix these files, e.g. one of the files contains a duplicate shortcode.