fix(alert): Ignore ipmi Entity Presence type alert (canonical#101)

* fix(alert): Ignore ipmi Entity Presence type alert Alert rule ipmi_generic_sensor_value ignoe type="Entity Presence" * docs: Change the wording of alert description
dashmage · Nov 16, 2023 · f084905 · f084905
1 parent 15c02a2
commit f084905
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/prometheus_alert_rules/ipmi_sensors.yaml b/src/prometheus_alert_rules/ipmi_sensors.yaml
@@ -75,13 +75,13 @@ groups:
             LABELS = {{ $labels }}
 
     - alert: IPMISensorStateNotOk
-      expr: ipmi_generic_sensor_value{state=~"Warning|Critical"}
+      expr: ipmi_generic_sensor_value{state=~"Warning|Critical", type!="Entity Presence"}
       for: 0m
       labels: 
         severity: "{{ toLower $labels.state }}"
       annotations:
         summary: IPMI sensor value in {{ toLower $labels.state }} state. (instance {{ $labels.instance }})
         description: |
-          A sensor value, recorded by ipmi sensor, in {{ toLower $labels.state }} state.
+          A sensor value, recorded by ipmi sensor, in {{ toLower $labels.state }} state. Entity Presence sensors are ignored.
             VALUE = {{ $value }}
             LABELS = {{ $labels }}
diff --git a/tests/unit/test_alert_rules/test_ipmi_sensors.yaml b/tests/unit/test_alert_rules/test_ipmi_sensors.yaml
@@ -214,6 +214,8 @@ tests:
         values: '1x15'
       - series: ipmi_generic_sensor_value{state="Critical", instance="ubuntu-12"}
         values: '50x15'
+      - series: ipmi_generic_sensor_value{state="Critical", instance="ubuntu-12", type="Entity Presence"}
+        values: '50x15'
 
     alert_rule_test:
       - eval_time: 0m
@@ -226,7 +228,7 @@ tests:
             exp_annotations:
               summary: IPMI sensor value in warning state. (instance ubuntu-11)
               description: |
-                A sensor value, recorded by ipmi sensor, in warning state.
+                A sensor value, recorded by ipmi sensor, in warning state. Entity Presence sensors are ignored.
                   VALUE = 20
                   LABELS = map[__name__:ipmi_generic_sensor_value instance:ubuntu-11 state:Warning]
           - exp_labels:
@@ -236,6 +238,6 @@ tests:
             exp_annotations:
               summary: IPMI sensor value in critical state. (instance ubuntu-12)
               description: |
-                A sensor value, recorded by ipmi sensor, in critical state.
+                A sensor value, recorded by ipmi sensor, in critical state. Entity Presence sensors are ignored.
                   VALUE = 50
                   LABELS = map[__name__:ipmi_generic_sensor_value instance:ubuntu-12 state:Critical]