Revamp gitian building guides #3748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
thephez
reviewed
Sep 29, 2020
doc/gitian-building.md
Outdated
|
|
||
| service apt-cacher-ng restart | ||
| ``` | ||
| You can also mail the files to Wladimir ([email protected]) and he will commit them. |
There was a problem hiding this comment.
I don't think Wladimir is going to be very helpful for us :-)
Signed-off-by: pasta <[email protected]>
thephez
reviewed
Sep 29, 2020
| ------------------ | ||
| In order to sign builds for macOS, you need to download the free SDK and extract a file. The steps are described [here](./gitian-building/gitian-building-mac-os-sdk.md). Alternatively, you can skip the macOS build by adding `--os=lw` below. |
There was a problem hiding this comment.
Don't think the ./ is needed
Suggested change
| In order to sign builds for macOS, you need to download the free SDK and extract a file. The steps are described [here](./gitian-building/gitian-building-mac-os-sdk.md). Alternatively, you can skip the macOS build by adding `--os=lw` below. | |
| In order to sign builds for macOS, you need to download the free SDK and extract a file. The steps are described [here](gitian-building/gitian-building-mac-os-sdk.md). Alternatively, you can skip the macOS build by adding `--os=lw` below. |
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
thephez
reviewed
Sep 30, 2020
| Now, run gitian-build.py script in setup mode. You may get asked to enter your password. | ||
| ``` | ||
| ./gitian-build.py -V lxc --setup $NAME $VERSION |
There was a problem hiding this comment.
Why specify -V lxc? That's only necessary if someone doesn't have Docker, right?
There was a problem hiding this comment.
It's how I've always done it on ubuntu
|
@PastaPastaPasta linter is unhappy |
|
This pull request has conflicts, please rebase. |
|
Closed due to gitian removing: #5756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pasta [email protected]