fix: adjusted nSuperblockMaturityWindow to new logic for devnet/testnet #5560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Since #5525, MNs during the maturity window, will propose new triggers.
In
CGovernanceManager::CreateSuperblockCandidate
, SuperBlock creation is skipped when the bellow check is true:if (nHeight % Params().GetConsensus().nSuperblockCycle < Params().GetConsensus().nSuperblockCycle - Params().GetConsensus().nSuperblockMaturityWindow) return std::nullopt;
Hence, the value of
nSuperblockMaturityWindow
must be less thannSuperblockCycle
and greater than 0.What was done?
Changed
nSuperblockMaturityWindow
for devnet and Testnet chain parameters to the following values:nSuperblockCycle
= 24nSuperblockMaturityWindow
= 8How Has This Been Tested?
Breaking Changes
Checklist: