Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusted nSuperblockMaturityWindow to new logic for devnet/testnet #5560

Merged

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Aug 31, 2023

Issue being fixed or feature implemented

Since #5525, MNs during the maturity window, will propose new triggers.

In CGovernanceManager::CreateSuperblockCandidate, SuperBlock creation is skipped when the bellow check is true:

if (nHeight % Params().GetConsensus().nSuperblockCycle < Params().GetConsensus().nSuperblockCycle - Params().GetConsensus().nSuperblockMaturityWindow) return std::nullopt;

Hence, the value of nSuperblockMaturityWindow must be less than nSuperblockCycle and greater than 0.

What was done?

Changed nSuperblockMaturityWindow for devnet and Testnet chain parameters to the following values:

nSuperblockCycle = 24
nSuperblockMaturityWindow = 8

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides added this to the 20 milestone Aug 31, 2023
@ogabrielides ogabrielides changed the title fix: adjusted nSuperblockMaturityWindow to new logic for devnet/test fix: adjusted nSuperblockMaturityWindow to new logic for devnet/testnet Aug 31, 2023
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, utACK

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit d9f815d into dashpay:develop Aug 31, 2023
10 checks passed
@ogabrielides ogabrielides deleted the sbmaturitywindow_update branch August 31, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants