Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: correct calculation of coinbasevalue in feature_asset_locks.py #5603

Merged
merged 3 commits into from
Oct 11, 2023
Merged

test: correct calculation of coinbasevalue in feature_asset_locks.py #5603

merged 3 commits into from
Oct 11, 2023

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 6, 2023 •
edited
Loading

Issue being fixed or feature implemented

Fixed a problem forgotten in #5588 in feature_asset_locks.py.

What was done?

Avoid floating operations when calculating coinbasevalue

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@ogabrielides ogabrielides added this to the 20 milestone Oct 6, 2023
UdjinM6
UdjinM6 requested changes Oct 6, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍 let's maybe make 100% identical

test/functional/feature_asset_locks.py Outdated Show resolved Hide resolved
@ogabrielides ogabrielides requested a review from UdjinM6 October 6, 2023 11:21
UdjinM6
UdjinM6 previously approved these changes Oct 6, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

knst
knst previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thanks for figuring this issue out

@ogabrielides ogabrielides dismissed stale reviews from knst and UdjinM6 via 70edf36 October 7, 2023 09:59
@ogabrielides ogabrielides requested review from UdjinM6 and knst October 7, 2023 10:00
knst
knst previously approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

UdjinM6
UdjinM6 previously approved these changes Oct 7, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This pull request has conflicts, please rebase.

@ogabrielides ogabrielides dismissed stale reviews from UdjinM6 and knst via 208ba2b October 9, 2023 14:46
@ogabrielides ogabrielides requested review from UdjinM6 and knst October 9, 2023 14:51
UdjinM6
UdjinM6 approved these changes Oct 9, 2023
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 5ca6382 into dashpay:develop Oct 11, 2023
9 checks passed
@ogabrielides ogabrielides deleted the fix_asset_lock_test branch October 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
4 participants
@ogabrielides @knst @UdjinM6 @PastaPastaPasta