Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new -llmqmnhf param for devnet #5634

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

knst
Copy link
Collaborator

@knst knst commented Oct 20, 2023

Issue being fixed or feature implemented

By default consensus for devnet if 50_60 that is way too much:

        consensus.llmqTypeMnhf = Consensus::LLMQType::LLMQ_50_60;

So, quorum list on devnet-ouzo is empty:

{
  "llmq_50_60": [
  ],

What was done?

Adds new -llmqmnhf param for devnet to change quorum params dynamically.

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20 milestone Oct 20, 2023
@knst knst requested a review from PastaPastaPasta October 20, 2023 16:06
UdjinM6
UdjinM6 previously approved these changes Oct 20, 2023
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

@knst
Copy link
Collaborator Author

knst commented Oct 20, 2023

@UdjinM6 sorry, I just added one more fix dropped it

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK :)

@PastaPastaPasta PastaPastaPasta merged commit 9a60987 into dashpay:develop Oct 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants